Page MenuHomePhabricator
Create Task
Maniphest T212171

Don't show a fatal error to users that aren't logged in
Closed, ResolvedPublic
Actions

Description

If you access EventMetrics with a URL and you are not logged in (don't have a valid session), you receive a fatal error.

Example: https://eventmetrics.wmflabs.org/programs/1/events/47/revisions?format=wikitext

We should catch the user that's not logged in and redirect to / or something that helps the user. Ideally, we'd show a message like, "You must be logged in to see that page, please log in." After logging in, the user would be redirected to the page in the original request.

Related Objects

Event Timeline

• aezell created this task.Dec 17 2018, 11:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 17 2018, 11:10 PM
• aezell moved this task from Backlog to To be estimated on the Event Metrics board.Dec 17 2018, 11:10 PM
• aezell closed this task as Invalid.Dec 17 2018, 11:24 PM
• aezell added a subscriber: MusikAnimal.

@MusikAnimal fixed this as I was writing the task.

Thanks!

MusikAnimal changed the task status from Invalid to Resolved.Dec 17 2018, 11:24 PM

My mistake! After deploying 47ec13b I forgot to update production's parameters.yml, which is why we were getting that error. The behaviour you suggest is what it does now that I've fixed it :) It does not redirect back to the original target after logging in, though. For that there's T187934

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL