Page MenuHomePhabricator

[minor] Help panel: White space is a valid input in a question
Closed, DeclinedPublic

Description

  1. Click on the Help panel and click in "Post your question ..." text box. The 'Continue' button is grey (a correct behavior).
  1. Press a space bar several times - empty spaces will be entered - the 'Continue' button becomes active (an incorrect behavior):

  1. Click 'Continue' - the next step does not even show the mouse pointer in the field, the "Post my question" is active (incorrect behavior).

  1. After posting an empty question on the Help desk, the entry looks like this:

Interesting, that when such entry is edited, the empty lines are preserved, so the editing mode will display the entered empty lines:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 18 2018, 12:58 AM

@kostajh: I checked a little bit for xss samples and also for some of the examples in https://www.mediawiki.org/wiki/Help:Magic_words#Page_names. The page/sections were not broken as far as I could see.
The following example I think it's the expected result:

== [[:{{BASEPAGENAME}}]] == 
<code> test </code>

will output:

JTannerWMF moved this task from Inbox to Current Sprint on the Growth-Team board.Jan 2 2019, 6:06 PM
JTannerWMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.

I'm not sure if this important enough to address yet. It's definitely the sort of thing we will be able to find out after initial usage. The HelpPanel schema will be recording length of message, and we'll of course be able to see content of message from the revision history.

@kostajh -- does addressing something like this mean adding a whole new capability to validate inputs? And then we would be able to add other rules, as well?

does addressing something like this mean adding a whole new capability to validate inputs? And then we would be able to add other rules, as well?

@MMiller_WMF yeah, it could either be very narrow for this particular example (check if the content is empty characters) or it could be more flexible so we could add more rules later. I'm wondering if we could also use Special:AbuseFilter to create rules for help panel generated edits.

Good to know. Let's not worry about this issue for now. We'll see if it becomes a problem. I am putting this into the Q3 column.

MMiller_WMF moved this task from Inbox to Q2 2019-20 on the Growth-Team board.Jan 2 2019, 10:38 PM
kostajh removed kostajh as the assignee of this task.Feb 11 2019, 6:21 PM
kostajh added a subscriber: kostajh.
JTannerWMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.

Are there updated requirements for this? I can think of many other invalid inputs beyond a single or multiple spaces, is that the only one we want to address now?

@Etonkovidova -- I think you might be best to answer @kostajh's question.

For example:

.

And so on. And if we start thinking about character length as a proxy for what's a valid question, we need to think about the character limits being different in kowiki vs cswiki, etc. Could we use AbuseFilter configured per-wiki for this?

Etonkovidova closed this task as Declined.Apr 2 2019, 7:15 PM

@kostajh I checked several examples of input that might be problematic - no problem was found.

<!--T:1--> 
"<translate>
{{ping|Username}}
{{FlowMention|Username}}
{{ {{{|safesubst:}}}#time:i}}
{{CURRENTTIME}}
&#8035;

[[De:Foo|De:Foo]]

I'm closing this task as 'Declined' since it's a minor issue and fixing it will pose more questions than the scope of the issue deserves.