SpecialBaseDistributor.php: PHP Notice: Undefined variable: downloadImg
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	zeljkofilipin
	Dec 18 2018, 2:47 PM

Description

Noticed after deploying 1.33.0-wmf.9 to group 0:

[XBkHzgpAAEUAAGeCR3oAAACB] /wiki/Special:ExtensionDistributor?extdistname=PropertySuggester&extdistversion=REL1_30   ErrorException from line 317 of /srv/mediawiki/php-1.33.0-wmf.9/extensions/ExtensionDistributor/includes/specials/SpecialBaseDistributor.php: PHP Notice: Undefined variable: downloadImg

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.12.18/mediawiki?id=AWfBxoWKxYA-x_UcVKB-&_g=h@bfc149c

Details

	Subject	Repo	Branch	Lines +/-
	Follow-up f686d348: No need for an <img> tag any more	mediawiki/extensions/ExtensionDistributor	wmf/1.33.0-wmf.9	+0 -1
	Follow-up f686d348: No need for an <img> tag any more	mediawiki/extensions/ExtensionDistributor	master	+0 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	zeljkofilipin	T206663 1.33.0-wmf.9 deployment blockers
		Resolved	PRODUCTION ERROR	Jdforrester-WMF	T212217 ErrorException from line 317 of /srv/mediawiki/php-1.33.0-wmf.9/extensions/ExtensionDistributor/includes/specials/SpecialBaseDistributor.php: PHP Notice: Undefined variable: downloadImg

Event Timeline

zeljkofilipin created this task.Dec 18 2018, 2:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 18 2018, 2:47 PM

zeljkofilipin triaged this task as Unbreak Now! priority.Dec 18 2018, 2:48 PM

zeljkofilipin added a parent task: T206663: 1.33.0-wmf.9 deployment blockers.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptDec 18 2018, 2:48 PM

Changes in ExtensionDistributor since 1.33.0-wmf.8 (MediaWiki_1.33/wmf.9/Changelog#ExtensionDistributor):

Looks like $downloadImg was removed in 479701:

includes/specials/SpecialBaseDistributor.php:

...
- $downloadImg = "$wgExtensionAssetsPath/ExtensionDistributor/download.png";
...

Pinging people involved in the patch: @Esanders @Jdforrester-WMF @Legoktm

Meh.

Change 480515 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/ExtensionDistributor@master] Follow-up f686d348: No need for an <img> tag any more

https://gerrit.wikimedia.org/r/480515

gerritbot added a project: Patch-For-Review.Dec 18 2018, 3:40 PM

Change 480515 merged by jenkins-bot:
[mediawiki/extensions/ExtensionDistributor@master] Follow-up f686d348: No need for an <img> tag any more

https://gerrit.wikimedia.org/r/480515

Change 480578 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/ExtensionDistributor@wmf/1.33.0-wmf.9] Follow-up f686d348: No need for an <img> tag any more

https://gerrit.wikimedia.org/r/480578

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.12; 2019-01-08).Dec 18 2018, 9:01 PM

Is this resolved? Train is blocked on moving forward until this is resolved.

In T212217#4833569, @zeljkofilipin wrote:

Is this resolved? Train is blocked on moving forward until this is resolved.

the backport needs merging/deploying.

Change 480578 merged by jenkins-bot:
[mediawiki/extensions/ExtensionDistributor@wmf/1.33.0-wmf.9] Follow-up f686d348: No need for an <img> tag any more

https://gerrit.wikimedia.org/r/480578

Mentioned in SAL (#wikimedia-operations) [2018-12-19T16:57:36Z] <hashar@deploy1001> Synchronized php-1.33.0-wmf.9/extensions/ExtensionDistributor/includes/specials/SpecialBaseDistributor.php: Follow-up f686d348: No need for an <img> tag any more - T212217 (duration: 00m 52s)