Page MenuHomePhabricator

Jade Wireframes: Entity edit mode
Closed, DuplicatePublic

Description

Design a wireframe for what the editing view of a Jade page might look like.

From a Jade page, a user should be able to:

  • Review current proposals and endorsements
  • Add a new proposal
  • Add a new endorsement

Event Timeline

Harej triaged this task as Medium priority.

Would this necessarily be separate from the view mode? I'm guessing not, but it might be good to spec out a set of patterns for making various types of judgment data editable. E.g. what kind of controls will we use for booleans (damaging), single-select (articlequality), or multi-select (drafttopic).

Even if they are the same page, a page might look different while you're in edit mode compared to if you're just reading it. (It might not be, though! Depends on what you come up with.)

Halfak renamed this task from Jade Wireframes: Entry edit mode to Jade Wireframes: Entity edit mode.Jan 14 2019, 9:11 PM
Halfak claimed this task.

https://docs.google.com/drawings/d/1fP-4Tmn4bDDLWKD_Uu_W0xQNM-QyRc4LDKQTkKNp_fc/edit covers a few different types of edits someone might do.

Menu items allow "edit", "details", "move", and "remove" where relevant. Editing happens within the view with a "✔ publish" and "✗ cancel" buttons inline. The "details" dialog makes metadata available to the UI. The goal here is not to replicate all of history but instead to provide some useful details for review.

My thought is that "move" only shows up for one's own endorsements. It's really just a convenience since "remove" and "endorse" perform roughly the same action.

Editing someone else's endorsement could be discouraged through the UI by a modal interruption ("You're editing someone else's endorsement. Are you sure?").

Harej raised the priority of this task from Medium to High.Apr 2 2019, 9:19 PM
Harej moved this task from Unsorted to New development on the Machine-Learning-Team board.
Harej removed Harej as the assignee of this task.Jul 3 2019, 11:32 AM
Halfak updated the task description. (Show Details)