Page MenuHomePhabricator
Create Task
Maniphest T212459

Specific sequence of steps can lead to crash
Closed, ResolvedPublic
Actions

Description

https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=10907297

Manually closing all open article tabs, then pressing the "home" soft key, and relaunching the Wikipedia app results in the app crashing on startup. A subsequent attempt to open the app results in the app launching successfully.

Details

SubjectRepoBranchLines +/-
Fix unnecessary instantiation of PageActivity when no tabs available.apps/android/wikipediamaster+1 -1
Customize query in gerrit

Event Timeline

LGoto created this task.Dec 20 2018, 9:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2018, 9:07 PM
Dbrant renamed this task from Possible bug with closing tabs to Specific sequence of steps can lead to crash.Jan 2 2019, 2:41 PM
Dbrant updated the task description. (Show Details)
• Charlotte edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington); removed Wikipedia-Android-App-Backlog.Jan 7 2019, 5:39 PM
Dbrant claimed this task.Jan 15 2019, 7:45 PM
gerritbot subscribed.Jan 15 2019, 7:47 PM

Change 484559 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Fix unnecessary instantiation of PageActivity when no tabs available.

https://gerrit.wikimedia.org/r/484559

gerritbot added a project: Patch-For-Review.Jan 15 2019, 7:47 PM
Dbrant moved this task from Backlog to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.Jan 15 2019, 7:47 PM
gerritbot added a comment.Jan 16 2019, 6:19 PM

Change 484559 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix unnecessary instantiation of PageActivity when no tabs available.

https://gerrit.wikimedia.org/r/484559

Dbrant moved this task from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.Jan 17 2019, 3:18 PM
ABorbaWMF moved this task from QA signoff to Ready for signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.Jan 18 2019, 7:39 PM
ABorbaWMF subscribed.

Looks good to me on 2.7.269-alpha-2019-01-18 and a few of the previous builds.

Dbrant closed this task as Resolved.Mar 6 2019, 7:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL