Page MenuHomePhabricator

Upgrade WikiApiary to foreground version 2.x
Open, Needs TriagePublic

Description

Event Timeline

Dinoguy1000 renamed this task from Upgrade Wikiapriary to foreground version 2.x to Upgrade WikiApiary to foreground version 2.x.Dec 20 2018, 11:39 PM
Kghbln added subscribers: Dinoguy1000, Kghbln.EditedDec 21 2018, 5:23 PM

Yeah, the templates have to be redone when it comes to the tabs. @Dinoguy1000 Would you like to take on this task so once the wiki is upgraded it is just a copy and paste of the new template code? This would be awesome.

I can try, though I'm not familiar with the inner workings of WikiApiary's templates yet, and I'm not sure just what redoing the tabs would require.

It is not too hard and probably just a matter of doing something like this, i.e. replacing div class with dl class etc. Foreground is documented here.

This edit fixed the tabs for me; does anything else need to be done for this ticket?

Kghbln added a comment.Jun 4 2019, 9:46 PM

Foreground 2.x.x. comes with Foundation 5 meaning that all tabs within the templates need to be adapted for the change.

After spending a half hour trying and failing to get the new syntax to work, I checked, and it turns out WikiApiary is still on Foreground 1.2.0. And checking some of the old revisions of the Tabs page on the Foreground wiki, it appears the old syntax doesn't function in Foreground 2.x.x (all tab names and content are just displayed, simultaneously, as plaintext).

Kghbln added a comment.Jun 5 2019, 2:38 PM

Well, yes, this is about upgrading to Foreground 2.x. ;) However your work was not wasted at all since we can revert to the converted version of the template soon after the upgrade. Thanks a lot for going at it!

Well, I didn't actually save anything, so at this time there isn't anything to revert to. =) I think it won't take nearly as much time and effort to redo the work the second time around, though.

On a related note, I'd like to point out that the Tabs documentation on the Foreground wiki is pretty terrible - it only gives some example code, without explaining what parts of the code are actually significant for the functionality and how/why. As far as I could see, there isn't even a sandbox area where visitors could play around with the Foreground features.

Kghbln added a comment.Jun 6 2019, 3:05 PM

Well, I didn't actually save anything, so at this time there isn't anything to revert to. =) I think it won't take nearly as much time and effort to redo the work the second time around, though.

What a shame. This would have saved some time. Still, you learned something which still lies ahead for me.

On a related note, I'd like to point out that the Tabs documentation on the Foreground wiki is pretty terrible - it only gives some example code, without explaining what parts of the code are actually significant for the functionality and how/why.

Affirmative. We should at least link to the related Foundation docu.

As far as I could see, there isn't even a sandbox area where visitors could play around with the Foreground features.

Well, if there is note, go forward and create one.

Well, I didn't actually save anything, so at this time there isn't anything to revert to. =) I think it won't take nearly as much time and effort to redo the work the second time around, though.

What a shame. This would have saved some time. Still, you learned something which still lies ahead for me.

I didn't actually get it to the point of being savable: I got the markup converted, but since the markup didn't actually work, I didn't see the point in making the new-syntax tabs properly auto-hide like the current ones do.

Affirmative. We should at least link to the related Foundation docu.

Do you have a link to this documentation handy?

Well, if there is note, go forward and create one.

Maybe later. =)

Kghbln added a comment.EditedJun 8 2019, 9:21 PM

Do you have a link to this documentation handy?

I guess it is this one, only did a quick and dirty internet search though: https://foundation.zurb.com/sites/docs/v/5.5.3/components/tabs.html#tabs-deeplink-3