| Volker_E | |
| Dec 21 2018, 12:16 AM |
| F27856437: IMG_6670.PNG | |
| Jan 11 2019, 8:41 PM |
| F27856444: IMG_6671.PNG | |
| Jan 11 2019, 8:41 PM |
| F27856441: IMG_6672.PNG | |
| Jan 11 2019, 8:41 PM |
| F27857046: Chrome-checkboxes.gif | |
| Jan 11 2019, 8:41 PM |
| F27690510: image.png | |
| Dec 21 2018, 12:16 AM |
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/GrowthExperiments | master | +12 -10 | Welcome survey C: fix toggles style |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | MMiller_WMF | T206365 [EPIC] Growth: Welcome survey | |||
| Resolved | SBisson | T207717 Personalized first day: build Variation C | |||
| Resolved | SBisson | T212479 UI consistency issues of Variation C |
Change 481149 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Welcome survey C: fix toggles style
hi @Volker - re: the last item you added about the different transition in the task description after @SBisson's patch - we can use the standard transition
Change 481149 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Welcome survey C: fix toggles style
@RHo - two things:
(1) Accent10 and Accent50 - it's ok to have them both on the same form? Accent50 for buttons (indicating clickability) and Accent10 for selected options.
 |  |  |
(2) Checked UI for mobile, Safari, and IE11, FF - all looks fine. But the checkboxes are visible in Chrome (the screenshot is a gif - click on it for animation) :
user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36
Thanks @Etonkovidova for the screenshots.
Answering (1): That's our current standard interaction pattern, Accent10 for actively clicked/selected/toggled interaction elements, Accent50 for primary, progressive buttons.
Thanks @Etonkovidova - I think it is acceptable to have the visible checkboxes on Chrome, and per @Volker_E 's the "selected button" using Accent10 is expected (an oversight on my part earlier). LGTM to sign-off.