Page MenuHomePhabricator
Create Task
Maniphest T212524

Upgrade Netbox to 2.5.x
Closed, ResolvedPublic
Actions

Description

Netbox is currently in the 2.4.x versions. 2.5 depends on Python 3.5 is the only real caveat.

  • Write sanitize / dump script for production Netbox -> test Netbox
  • Test upgrade in Automation Framework WMCS project
    • Build new netbox instance on Stretch at version 2.4.x
    • Rebuild netbox instance using scapish / puppet
    • Install sanitized dump
    • Test upgrade to 2.5 in place, verify
    • Update deploy repository
      • Update our copy of upstream to v2.5.3 after reviewing
      • Resubmit deploy repository with our upstream.
  • Update production Netbox
  • Port existing reports to 2.5 (there are changes to console connections and other things)

Details

ProjectBranchLines +/-Subject
operations/software/netbox-reportsmaster+1 -1management.py: trivial change to adapt for Netbox 2.5+
operations/software/netbox-deploymaster+16 -39Upgrade netbox to v2.5.3
Customize query in gerrit

Related Objects
Search...

Event Timeline

• crusnov created this task.Dec 21 2018, 6:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 21 2018, 6:41 PM
• crusnov added a parent task: T205868: Expand Netbox usage - Q2 2018-19 Goal.Dec 21 2018, 6:43 PM
ayounsi added a subscriber: ayounsi.Dec 21 2018, 6:44 PM
• crusnov triaged this task as Medium priority.Dec 21 2018, 6:46 PM
• crusnov added a project: SRE-tools.
• crusnov moved this task from Backlog to In Progress on the SRE-tools board.
• crusnov removed a subscriber: Aklapper.
Volans removed a parent task: T205868: Expand Netbox usage - Q2 2018-19 Goal.Jan 2 2019, 4:24 PM
• crusnov added a comment.Jan 3 2019, 8:01 PM

Sanitization list (so far, RFC):

  • MAC addresses
  • Serial numbers
  • Circuit IDs
• crusnov added a parent task: T213114: Q3 2018/19 Goal: TEC6: Build automated workflows for server provisioning (Tracking Task).Jan 14 2019, 5:15 PM
• crusnov added a comment.Jan 14 2019, 7:22 PM

Updated https://wikitech.wikimedia.org/wiki/Netbox with sanitizer script. If anyone has opinions on copying over passwords I'm interested, for the time being i'll blank them all except for mine for convenience.

Volans added a comment.Jan 14 2019, 9:30 PM
In T212524#4878476, @crusnov wrote:

Updated https://wikitech.wikimedia.org/wiki/Netbox with sanitizer script. If anyone has opinions on copying over passwords I'm interested, for the time being i'll blank them all except for mine for convenience.

The netbox instance in WMCS should not use the same LDAP config of production and also should not use the same passwords (I'm not sure what Netbox actually saves as password when logging in via LDAP).
A solution could be to add a test user via the Django CLI on the WMCS instance once imported.

• crusnov added a comment.Jan 14 2019, 9:34 PM
In T212524#4878873, @Volans wrote:
In T212524#4878476, @crusnov wrote:

Updated https://wikitech.wikimedia.org/wiki/Netbox with sanitizer script. If anyone has opinions on copying over passwords I'm interested, for the time being i'll blank them all except for mine for convenience.

The netbox instance in WMCS should not use the same LDAP config of production and also should not use the same passwords (I'm not sure what Netbox actually saves as password when logging in via LDAP).
A solution could be to add a test user via the Django CLI on the WMCS instance once imported.

Sounds good to me. Thanks for the feedback.

• crusnov updated the task description. (Show Details)Jan 15 2019, 6:39 PM
• crusnov updated the task description. (Show Details)Jan 16 2019, 7:42 PM
• crusnov updated the task description. (Show Details)Jan 18 2019, 4:28 AM
gerritbot added a subscriber: gerritbot.Jan 18 2019, 4:29 AM

Change 485142 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/software/netbox-deploy@master] Upgrade netbox to v2.5.2

https://gerrit.wikimedia.org/r/485142

gerritbot added a project: Patch-For-Review.Jan 18 2019, 4:29 AM
• crusnov updated the task description. (Show Details)Jan 22 2019, 9:05 PM
• crusnov updated the task description. (Show Details)Jan 23 2019, 5:24 PM
gerritbot added a comment.Jan 23 2019, 11:06 PM

Change 485142 merged by CRusnov:
[operations/software/netbox-deploy@master] Upgrade netbox to v2.5.3

https://gerrit.wikimedia.org/r/485142

Stashbot added a subscriber: Stashbot.Jan 23 2019, 11:28 PM

Mentioned in SAL (#wikimedia-operations) [2019-01-23T23:28:51Z] <crusnov@deploy1001> Started deploy [netbox/deploy@aa3c342]: Upgrade netbox to 2.5.3 - T212524

Stashbot added a comment.Jan 23 2019, 11:32 PM

Mentioned in SAL (#wikimedia-operations) [2019-01-23T23:32:02Z] <crusnov@deploy1001> Finished deploy [netbox/deploy@aa3c342]: Upgrade netbox to 2.5.3 - T212524 (duration: 04m 46s)

hashar mentioned this in T214560: [CVE-2017-18342] pyyaml vulnerability in netbox deploy repository.Jan 24 2019, 8:54 AM
Stashbot added a comment.Jan 25 2019, 1:18 AM

Mentioned in SAL (#wikimedia-operations) [2019-01-25T01:18:24Z] <crusnov@deploy1001> Started deploy [netbox/deploy@7770453]: Upgrade netbox to 2.5.3 - T212524

Stashbot added a comment.Jan 25 2019, 1:26 AM

Mentioned in SAL (#wikimedia-operations) [2019-01-25T01:26:08Z] <crusnov@deploy1001> Finished deploy [netbox/deploy@7770453]: Upgrade netbox to 2.5.3 - T212524 (duration: 07m 43s)

Stashbot added a comment.Jan 25 2019, 1:27 AM

Mentioned in SAL (#wikimedia-operations) [2019-01-25T01:27:33Z] <crusnov@deploy1001> Started deploy [netbox/deploy@7770453]: Upgrade netbox to 2.5.3 - T212524 Try 2

Stashbot added a comment.Jan 25 2019, 1:28 AM

Mentioned in SAL (#wikimedia-operations) [2019-01-25T01:28:04Z] <crusnov@deploy1001> Finished deploy [netbox/deploy@7770453]: Upgrade netbox to 2.5.3 - T212524 Try 2 (duration: 00m 31s)

Stashbot added a comment.Jan 25 2019, 1:33 AM

Mentioned in SAL (#wikimedia-operations) [2019-01-25T01:33:14Z] <crusnov@deploy1001> Started deploy [netbox/deploy@7770453]: Cleanup deploy - T212524

Stashbot added a comment.Jan 25 2019, 1:33 AM

Mentioned in SAL (#wikimedia-operations) [2019-01-25T01:33:25Z] <crusnov@deploy1001> Finished deploy [netbox/deploy@7770453]: Cleanup deploy - T212524 (duration: 00m 11s)

• crusnov updated the task description. (Show Details)Jan 25 2019, 1:50 AM
gerritbot added a comment.Jan 31 2019, 8:41 PM

Change 487380 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/software/netbox-reports@master] management.py: trivial change to adapt for Netbox 2.5+

https://gerrit.wikimedia.org/r/487380

gerritbot added a comment.Jan 31 2019, 9:45 PM

Change 487380 merged by Volans:
[operations/software/netbox-reports@master] management.py: trivial change to adapt for Netbox 2.5+

https://gerrit.wikimedia.org/r/487380

• crusnov moved this task from In Progress to In Code Review on the SRE-tools board.Feb 2 2019, 10:06 PM
• crusnov moved this task from In Code Review to Pending release/deployment/testing on the SRE-tools board.Mar 18 2019, 11:06 PM
• crusnov closed this task as Resolved.Mar 19 2019, 6:14 PM
Volans mentioned this in T213114: Q3 2018/19 Goal: TEC6: Build automated workflows for server provisioning (Tracking Task).Nov 4 2019, 1:55 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 4 2019, 2:11 PM
• crusnov mentioned this in rOSNE8434ca18ef5f: management.py: trivial change to adapt for Netbox 2.5+.Dec 5 2019, 11:19 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL