Page MenuHomePhabricator
Create Task
Maniphest T212551

[minor] Help panel: the checkmark for "Your question has been posted" displayed on a new line
Closed, ResolvedPublic
Actions

Assigned To
SBisson
Authored By
Etonkovidova
Dec 22 2018, 1:44 AM
Tags
Referenced Files
F27857261: Screen Shot 2019-01-11 at 12.55.23 PM.png
Jan 11 2019, 8:59 PM
F27857245: IMG_6673.PNG
Jan 11 2019, 8:59 PM
F27846550: conf-wrap.png
Jan 10 2019, 7:16 PM
F27815805: IMG_6663.PNG
Jan 7 2019, 8:21 PM
F27700379: Screen Shot 2018-12-21 at 5.35.43 PM.png
Dec 22 2018, 1:44 AM
Subscribers
Aklapper
Etonkovidova
gerritbot
kostajh
RHo
SBisson

Description

In FF63 (Mac OS X) the checkmark is displayed on a different line:

Screen Shot 2018-12-21 at 5.35.43 PM.png (922×478 px, 259 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Help panel: force confirmation message on the same line as the iconmediawiki/extensions/GrowthExperimentsmaster+8 -1
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Dec 22 2018, 1:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 22 2018, 1:44 AM
Etonkovidova mentioned this in T209318: Help panel: allow users to "Ask a question" to help desk.Dec 22 2018, 1:49 AM
JTannerWMF moved this task from Inbox to Sprint 0 (Growth Team) on the Growth-Team board.Jan 2 2019, 6:04 PM
JTannerWMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 2 2019, 9:19 PM
kostajh added a comment.Jan 4 2019, 4:13 PM

@Etonkovidova I no longer see this in Firefox. Are you still seeing this?

kostajh claimed this task.Jan 4 2019, 6:20 PM
kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

I see it on my phone, though, so we should fix it there.

kostajh removed kostajh as the assignee of this task.Jan 4 2019, 7:41 PM
kostajh triaged this task as Medium priority.
kostajh moved this task from In Progress to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
Etonkovidova added a comment.Jan 7 2019, 8:21 PM
In T212551#4855750, @kostajh wrote:

I see it on my phone, though, so we should fix it there.

Yes, I saw it when testing T212901. The screenshot is here (iPhone 6S):

IMG_6663.PNG (1×640 px, 95 KB)

Etonkovidova mentioned this in T212901: Help panel: add space between paragraphs on confirmation screen in mobile view.Jan 7 2019, 8:26 PM
SBisson subscribed.Jan 10 2019, 7:16 PM

Is this wrapping acceptable?

conf-wrap.png (1×688 px, 89 KB)

gerritbot subscribed.Jan 10 2019, 7:22 PM

Change 483498 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Help panel: force confirmation message on the same line as the icon

https://gerrit.wikimedia.org/r/483498

gerritbot added a project: Patch-For-Review.Jan 10 2019, 7:22 PM
SBisson claimed this task.Jan 10 2019, 7:23 PM
SBisson moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
SBisson mentioned this in rEGRE3ad4f2c507b9: Help panel: force confirmation message on the same line as the icon.Jan 10 2019, 7:23 PM
RHo subscribed.Jan 10 2019, 7:45 PM
In T212551#4870830, @SBisson wrote:

Is this wrapping acceptable?

conf-wrap.png (1×688 px, 89 KB)

  • Yes, that's fine. The main thing is that the message is intended to start on the same line as the icon. The message wrapping to a second line is bound to occur in some language translations and smaller device widths anyway.
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 11 2019, 3:16 PM
gerritbot added a comment.Jan 11 2019, 3:19 PM

Change 483498 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help panel: force confirmation message on the same line as the icon

https://gerrit.wikimedia.org/r/483498

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.13; 2019-01-15).Jan 11 2019, 4:00 PM
Etonkovidova moved this task from QA to Design Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 11 2019, 8:59 PM

Both mobile and FF display the check mark inline:

IMG_6673.PNG (1×640 px, 78 KB)

Screen Shot 2019-01-11 at 12.55.23 PM.png (411×514 px, 54 KB)

RHo moved this task from Design Review to Needs PM Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 14 2019, 12:06 PM

LGTM

MMiller_WMF closed this task as Resolved.Jan 15 2019, 12:09 AM
MMiller_WMF moved this task from Needs PM Review to Epics In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
jijiki mentioned this in rEGRE1ec1f2fa6da6: Help panel: force confirmation message on the same line as the icon.Mar 18 2019, 4:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits