Page MenuHomePhabricator

Do not strip off addition in parenthesis in signature
Closed, ResolvedPublic

Description

For some days now, in signatures all additions in parenthesis are removed. E.g. if you are user "Test (Addition)", your signature will be "Test". This is bad, because you can't see the real username. If someone wants his addition removed, he can do this in his preferences, but this isn't a good standard behavior.


Version: unspecified
Severity: minor

Details

Reference
bz19261

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 10:40 PM
bzimport set Reference to bz19261.

Unable to reproduce on enwiki. It's probably a use of the pipe trick in an overridden system message on whatever wiki you're trying it on.

post wrote:

This happens on de.wikipedia.org. Before last week, everything was fine with "Test (Addition)". Only since a few days ago, the "transformation" mentioned above has been happening.

(In reply to comment #1)

Unable to reproduce on enwiki. It's probably a use of the pipe trick in an
overridden system message on whatever wiki you're trying it on.

I was able to reproduce it on enwiki by opening [[Special:Preferences]] and saving them without changes with a test account. I guess, somehow the signature gets saved as NULL or empty string.

[[MediaWiki:Signature]] default is "[[{{ns:user}}:$1|$2]]"

If the sig gets saved empty, and then gets actually used, you'll end up with:

[[User:Test (Addition)|]]

which will pipe-trick expand to:

[[User:Test (Addition)|Test]]

If the sig field is empty we should end up using the username instead for the $2 there... some funny value getting mistakenly used?

Andrew, sticking this back to you since it looks like a prefs saving or loading issue.

r51910 might be related, or might not.

(batch change)

Minor bugs that nevertheless need looking into

Hopefully resolved in r54585.

Note that you'll have to resave your preferences to fix it.

Hmm... looks like the base problem is that empty is being interpreted as "put empty in the sig" instead of as "use default sig" at signature replacement time.

We shouldn't be saving the username into preferences if it hasn't been explicitly typed; if the user changes their name, they should automatically pick up the new value.

Reverted in r55306.

ayg wrote:

r56102 says it fixes this, so I'm closing as FIXED.