icinga doesn't log ampersand in notes_url links
Closed, ResolvedPublic

Description

It has been noted today that urls to dashboards (i.e. in notes_url in icinga config) are not output to irc with ampersands in the query string, thus making the links not as useful. AFAICT the last message with & was on Nov 12th (reported below), which is one day earlier than when we switched to newer icinga on stretch in T202782. I'm assuming the upgrade is related and possibly the root cause.

20:05:45 -icinga-wm:#wikimedia-operations- PROBLEM - Memory correctable errors -EDAC- on thumbor1004 is CRITICAL: 4.001 ge 4 https://grafana.wikimedia.org/dashboard/db/host-overview?orgId=1&var-server=thumbor1004&var-datasource=eqiad%2520prometheus%252Fops
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Dec 28, 3:29 PM
herron triaged this task as Normal priority.Wed, Jan 2, 5:43 PM
herron added subscribers: Dzahn, colewhite.
Volans claimed this task.Wed, Jan 2, 5:48 PM

Change 481901 had a related patch set uploaded (by Volans; owner: Volans):
[operations/puppet@production] icinga: re-apply change for URL ampersends

https://gerrit.wikimedia.org/r/481901

Change 481901 merged by Volans:
[operations/puppet@production] icinga: re-apply change for URL ampersends

https://gerrit.wikimedia.org/r/481901

Mentioned in SAL (#wikimedia-operations) [2019-01-02T18:35:57Z] <volans> restarting icinga on icinga1001 T212669

Volans closed this task as Resolved.EditedWed, Jan 2, 6:38 PM

Fix applied, it required an Icinga restart. See the commit message for more details.

Wed 19:37:49   icinga-wm| RECOVERY - carbon-local-relay metric drops on graphite1004 is OK: OK: 
Less than 80.00% above the threshold [25.0]
https://grafana.wikimedia.org/dashboard/db/graphite-eqiad?orgId=1&panelId=29&fullscreen
https://grafana.wikimedia.org/dashboard/db/graphite-codfw?orgId=1&panelId=29&fullscreen