Page MenuHomePhabricator

Namespace selection labels are inconsistent
Open, Needs TriagePublic

Description

The labels for namespace selection are not the same: some contain paragraph tags, making them display on a separate line, but the first one does not, making it dispaly inline with the radio button. It looks like it might be something to do with the JS that makes the 'same as wiki name' bit work, because with JS turned off they are all on separate lines:

With JS:Without JS:
namespace-selection.png (205×437 px, 9 KB)
namespace-selection-nojs.png (282×387 px, 13 KB)

The HTML for these is this:

<ul>
<li><input name="config__NamespaceType" type="radio" value="site-name" checked="checked" class="enableForOther" rel="config_wgMetaNamespace" id="config__NamespaceType_site-name" tabindex="2" /> <label for="config__NamespaceType_site-name"><p>Same as the wiki name: $1</p></label></li>
<li><input name="config__NamespaceType" type="radio" value="generic" class="enableForOther" rel="config_wgMetaNamespace" id="config__NamespaceType_generic" tabindex="3" /> <label for="config__NamespaceType_generic"><p>Project</p></label></li>
<li><input name="config__NamespaceType" type="radio" value="other" class="enableForOther" rel="config_wgMetaNamespace" id="config__NamespaceType_other" tabindex="4" /> <label for="config__NamespaceType_other"><p>Other (specify)</p></label></li>
</ul>

It looks like those <p> tags shouldn't be there (block-level inside inline label is wrong isn't it?).