Insufficient polymorphism implementation of specialbots EditReplacement class
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xqt
	Jan 1 2019, 2:06 PM

Description

bot_choice.Option is derived by subclasses which sometimes overwrites stop properties and gives always False for example.

But specialbots.EditReplacement is derived from ChoiceException and UnhandledAnswer which sets a stop attribute.

ChoiceException is derived from StandardOption and Exception.
StandardOption is derived from Option and has a stop property which has to be set by a setter property. Otherwise it will fail.

UnhandledAnswer is an Exception which also sets a stop attribute.

See https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/321576/

Sample:

>>> import pwb, pywikibot as py
>>> from pywikibot.specialbots import EditReplacement
>>> raise EditReplacement

Traceback (most recent call last):
  File "pywikibot\specialbots.py", line 495, in __init__
    self.stop = True
AttributeError: can't set attribute
>>>

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	[bugfix] Fix polymorphism implementation of bot_choice.Option	pywikibot/core	master	+122 -25
	[bugfix] initialize super classes of EditReplacementError	pywikibot/core	master	+1 -2

Customize query in gerrit

Related Objects

Mentioned In: T215078: TypeError when running solve_disambiguation

Event Timeline

Xqt created this task.Jan 1 2019, 2:06 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJan 1 2019, 2:06 PM

Xqt claimed this task.Jan 1 2019, 2:07 PM

Xqt triaged this task as High priority.

Framawiki subscribed.Jan 1 2019, 3:51 PM

Xqt removed Xqt as the assignee of this task.Jan 1 2019, 6:59 PM

Change 482279 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Fix polymorphism implementation of bot_choice.Option

https://gerrit.wikimedia.org/r/482279

gerritbot added a project: Patch-For-Review.Jan 4 2019, 11:10 AM

Xqt claimed this task.Jan 4 2019, 11:10 AM

Mahveotm moved this task from Backlog to Needs Review on the Pywikibot board.Jan 27 2019, 1:37 PM

matej_suchanek mentioned this in T215078: TypeError when running solve_disambiguation.Feb 1 2019, 8:13 PM

Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 2 2021, 9:34 AM

Removing task assignee due to inactivity, as this open task has been assigned for more than two years (see emails sent to assignee on May26 and Jun17, and T270544). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be very welcome!

(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)

Change #1061144 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] initialize super classes of EditReplacementError

https://gerrit.wikimedia.org/r/1061144

gerritbot added a project: Patch-For-Review.Aug 10 2024, 12:33 PM

Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptAug 10 2024, 12:33 PM

Xqt claimed this task.Aug 10 2024, 12:33 PM

Change #1061144 merged by Xqt:

[pywikibot/core@master] [bugfix] initialize super classes of EditReplacementError

https://gerrit.wikimedia.org/r/1061144

Xqt closed this task as Resolved.Aug 10 2024, 4:33 PM

Change #482279 abandoned by Xqt:

[pywikibot/core@master] [bugfix] Fix polymorphism implementation of bot_choice.Option