MediaWiki API help page loads module 'mediawiki.searchSuggest' although there no search field
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Fomafix
	Jan 1 2019, 11:58 PM

Description

The MediaWiki API help on https://www.mediawiki.org/w/api.php loads the module 'mediawiki.searchSuggest' although there no search field. The module 'mediawiki.searchSuggest' is needed for search suggestions and should only loaded on pages contains a search field.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+2 -0	SkinApi: Do not load 'mediawiki.searchSuggest'

Customize query in gerrit

Event Timeline

Fomafix created this task.Jan 1 2019, 11:58 PM

Restricted Application added a project: Performance-Team. · View Herald TranscriptJan 1 2019, 11:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

(This is enqueued by Skin and not an issue with the ResourceLoader system itself.)

Change 481931 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] SkinApi: Do not load 'mediawiki.searchSuggest'

https://gerrit.wikimedia.org/r/481931

gerritbot added a project: Patch-For-Review.Jan 2 2019, 7:26 PM

Change 481931 merged by jenkins-bot:
[mediawiki/core@master] SkinApi: Do not load 'mediawiki.searchSuggest'

https://gerrit.wikimedia.org/r/481931

Fomafix closed this task as Resolved.Jan 2 2019, 11:11 PM

Fomafix assigned this task to matmarex.

Fomafix removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.12; 2019-01-08).Jan 3 2019, 12:00 AM