Page MenuHomePhabricator
Create Task
Maniphest T212752

MediaWiki API help page loads module 'mediawiki.searchSuggest' although there no search field
Closed, ResolvedPublic
Actions

Description

The MediaWiki API help on https://www.mediawiki.org/w/api.php loads the module 'mediawiki.searchSuggest' although there no search field. The module 'mediawiki.searchSuggest' is needed for search suggestions and should only loaded on pages contains a search field.

Event Timeline

Fomafix created this task.Jan 1 2019, 11:58 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptJan 1 2019, 11:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle edited projects, added DynamicPageList (Wikimedia); removed MediaWiki-ResourceLoader.Jan 2 2019, 2:20 AM
Krinkle edited projects, added MediaWiki-Interface; removed DynamicPageList (Wikimedia).
Krinkle added a subscriber: Krinkle.

(This is enqueued by Skin and not an issue with the ResourceLoader system itself.)

gerritbot added a subscriber: gerritbot.Jan 2 2019, 7:26 PM

Change 481931 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] SkinApi: Do not load 'mediawiki.searchSuggest'

https://gerrit.wikimedia.org/r/481931

gerritbot added a comment.Jan 2 2019, 11:10 PM

Change 481931 merged by jenkins-bot:
[mediawiki/core@master] SkinApi: Do not load 'mediawiki.searchSuggest'

https://gerrit.wikimedia.org/r/481931

Fomafix closed this task as Resolved.Jan 2 2019, 11:11 PM
Fomafix assigned this task to matmarex.
Fomafix removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL