Page MenuHomePhabricator
Create Task
Maniphest T212804

Add a dialog box to tell users they are leaving the page with unsaved changes
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

When an event organizer is adding usernames to the Participants and Categories filters, there is some ambiguity as to whether particular changes are saved or unsaved. This issue has been discussed extensively in T201710, and various solutions were entertained but put on hold. Meanwhile, we decided to address the most pressing part of the problem, which is that currently users who leave the page with unsaved changes get no warning.

New Functionality

  • When a user clicks to leave the Event Summary page (which is where the Participants and Categories filters live until we move them in Phase II), we will determine whether she has unsaved changes. If so, we will warn with a dialog box.
  • Text of dialog: Leave page? You have unsaved changes that will be lost. [Leave] [Stay]
    • If the user clicks Stay, the dialog to disappears and the user returns to the Setup page.
    • If the user clicks Leave, the dialog closes the the user progresses to whichever page she originally selected.

Related Objects

Event Timeline

• jmatazzoni triaged this task as Medium priority.Jan 2 2019, 7:38 PM
• jmatazzoni created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 2 2019, 7:38 PM
• jmatazzoni moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Jan 2 2019, 7:39 PM
• jmatazzoni moved this task from Backlog to To be estimated on the Event Metrics board.
• jmatazzoni mentioned this in T201710: Clarify when usernames in Participants list are saved or unsaved.Jan 2 2019, 7:45 PM
• jmatazzoni set the point value for this task to 3.Jan 9 2019, 12:59 AM
• jmatazzoni updated the task description. (Show Details)Jan 9 2019, 1:35 AM
• jmatazzoni moved this task from Needs Discussion to Up Next (May 6-17) on the Community-Tech board.Jan 15 2019, 10:31 PM
• jmatazzoni moved this task from To be estimated to Holding on the Event Metrics board.Jan 24 2019, 11:03 PM
• jmatazzoni moved this task from Up Next (May 6-17) to Product backlog on the Community-Tech board.Jan 24 2019, 11:36 PM

@Prtksxna, I'm moving this to stalled, since I see no point in adding the dialog for unsaved changes to the interim page. And I am currently assuming that we can specify the functionality we wanted (to save valid usernames) on the redesigned Setup page you are designing now. Should that not be the case, we can revive this ticket then.

• jmatazzoni moved this task from Holding to Stalled, Epic, Other, etc. on the Event Metrics board.Jan 24 2019, 11:36 PM
• jmatazzoni moved this task from Product backlog to Up Next (May 6-17) on the Community-Tech board.Feb 19 2019, 6:46 PM
• jmatazzoni added a project: Community-Tech-Sprint.Mar 27 2019, 11:10 PM
• Niharika moved this task from Up Next (May 6-17) to In Sprint 🏃‍♀️🏃‍♂️ on the Community-Tech board.Mar 28 2019, 11:30 PM
Mooeypoo moved this task from Ready to In Development on the Community-Tech-Sprint board.Mar 29 2019, 9:58 PM
Mooeypoo claimed this task.Mar 29 2019, 10:04 PM

Just note that browsers started considering these custom messages as security breach. They allow us to display a warning before navigating away, but not to set the text of that warning.

In chrome, it looks like this:

leave-site-alert-chrome.png (141×453 px, 12 KB)

And it will only appear if there are invalid participants in the form.

Mooeypoo added a comment.Mar 29 2019, 10:10 PM

PR is here: https://github.com/wikimedia/eventmetrics/pull/262

@jmatazzoni please verify that the behavior is okay (see my comment above). We can't set a custom note on that alert anymore, we can only display the default "Leave site?" alert. The PR does that only when there are invalid participants in the list, and the error message saying "there are invalid participants" should be sufficient in directing the user's attention there.

Is this change from the original spec okay? If so, I'll move to review.

• jmatazzoni added a comment.Mar 29 2019, 10:25 PM

The standard dialog box seems fine. Not ideal, but it's what users are used to. Let's try it.

Mooeypoo moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Mar 29 2019, 10:25 PM
Mooeypoo moved this task from Needs Review/Feedback to QA on the Community-Tech-Sprint board.Mar 31 2019, 1:30 AM
• jmatazzoni moved this task from QA to Product sign-off on the Community-Tech-Sprint board.Mar 31 2019, 6:13 PM
• jmatazzoni closed this task as Resolved.Mar 31 2019, 6:16 PM

I tested this and saw the dialog box on the Settings, Create a New Program and Event Summary pages when I tried to leave the pages with unsaved settings. Resolving this.

MusikAnimal moved this task from Product sign-off to Q3 2018-19 on the Community-Tech-Sprint board.Mar 31 2019, 10:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL