Page MenuHomePhabricator

'references' icon needs alignment
Closed, ResolvedPublic

Assigned To
Authored By
Volker_E
Jan 2 2019, 7:52 PM
Referenced Files
F27888808: image.png
Jan 14 2019, 7:20 PM
F27888815: image.png
Jan 14 2019, 7:20 PM
F27888823: image.png
Jan 14 2019, 7:20 PM
F27888805: image.png
Jan 14 2019, 7:20 PM
F27856514: references.svg
Jan 11 2019, 7:41 PM
F27856515: existing reference.svg
Jan 11 2019, 7:41 PM
F27778021: image.png
Jan 2 2019, 7:52 PM

Description

The 'references' icon seem to have gotten lost on overhaul. Current one is the unchanged one from before with 16x16px canvas.

image.png (301×1 px, 34 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@RHo Please have a look at this. Have searched through shared Illustrator files, but haven't found any updated one. Also please note that the latest icons are now part of Style Guide repo's 'WikimediaUI-icons.ai' file, so for an update we gonna push a new commit with changed file.

Change 483833 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] DropdownWidget: $handle needs to carry type="button"

https://gerrit.wikimedia.org/r/483833

Above patch was mistyped, doesn't belong here.

Hey @Volker - looks like both the updated references and existing reference icons were omitted in the export. Here are the updated icons as SVGs - thanks for your vigilance :)

Change 483991 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] icons: Update 'referenceExisting' and 'references'

https://gerrit.wikimedia.org/r/483991

Change 483991 merged by jenkins-bot:
[oojs/ui@master] icons: Update 'referenceExisting' and 'references'

https://gerrit.wikimedia.org/r/483991

Volker_E triaged this task as Medium priority.
Volker_E moved this task from Backlog to OOUI-0.30.2 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.30.2); removed OOUI.
Volker_E added a subscriber: RHo.

The icon are not aligned to the pixel grid, which makes them look blurry on non-high-resolution displays.

BeforeAfter
LTR
image.png (60×421 px, 2 KB)
image.png (60×421 px, 2 KB)
RTL
image.png (60×421 px, 3 KB)
image.png (60×421 px, 2 KB)

It's a trivial fix (the icons are drawn nicely on a pixel grid, but it is offset by 0.5px).

Change 484269 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] Align new icons to pixel grid

https://gerrit.wikimedia.org/r/484269

That's confusing as the originals were not aligned and cut off as they overflowed the 20x20 canvas and I've (thought to?) set up 'snap to pixel' option. Thanks for double-checking.

Change 484269 merged by jenkins-bot:
[oojs/ui@master] Align new icons to pixel grid

https://gerrit.wikimedia.org/r/484269

Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.

Change 486131 had a related patch set uploaded (by Jforrester; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.30.2

https://gerrit.wikimedia.org/r/486131

Change 486131 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.30.2

https://gerrit.wikimedia.org/r/486131