Page MenuHomePhabricator
Create Task
Maniphest T212893

Help panel: incorrect content section heading text color on mobile
Closed, ResolvedPublic
Actions

Description

Broken out from T211633:

This was fixed on desktop but not mobile.

Expected: {color: #54595d}
Artboard.png (171×331 px, 27 KB)
Actual: {color: #000}
image.png (414×634 px, 47 KB)

Details

SubjectRepoBranchLines +/-
Help Panel: Paragraph margin and section heading textmediawiki/extensions/GrowthExperimentsmaster+13 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

RHo created this task.Jan 3 2019, 8:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 3 2019, 8:18 PM
RHo mentioned this in T211633: Help panel: design tweaks.Jan 3 2019, 8:26 PM
RHo triaged this task as Medium priority.Jan 4 2019, 6:27 PM
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 4 2019, 6:31 PM
kostajh claimed this task.Jan 4 2019, 7:48 PM
kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot subscribed.Jan 4 2019, 8:14 PM

Change 482344 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Help Panel: Paragraph margin and section heading text

https://gerrit.wikimedia.org/r/482344

gerritbot added a project: Patch-For-Review.Jan 4 2019, 8:14 PM
kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 4 2019, 8:15 PM
kostajh mentioned this in rEGRE3b1631226219: Help Panel: Paragraph margin and section heading text.Jan 4 2019, 8:15 PM
gerritbot added a comment.Jan 4 2019, 9:22 PM

Change 482344 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help Panel: Paragraph margin and section heading text

https://gerrit.wikimedia.org/r/482344

MMiller_WMF added a parent task: T206711: [EPIC] Growth: help panel.Jan 4 2019, 10:34 PM
MMiller_WMF added subscribers: MMiller_WMF, JTannerWMF, Trizek-WMF and 6 others.
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 4 2019, 10:56 PM
Etonkovidova moved this task from QA to Design Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 8 2019, 12:11 AM

Seems to be fixed:

IMG_6665.PNG (1×640 px, 61 KB)

RHo moved this task from Design Review to Needs PM Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 8 2019, 12:24 PM

LGTM too

image.png (452×718 px, 39 KB)

MMiller_WMF closed this task as Resolved.Jan 15 2019, 12:11 AM
MMiller_WMF moved this task from Needs PM Review to Epics In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
jijiki mentioned this in rEGRE7a1dbbe9eff3: Help Panel: Paragraph margin and section heading text.Mar 18 2019, 4:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL