Help panel: Use ButtonWidget normal style for mobile confirmation screen
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RHo
	Jan 3 2019, 9:25 PM

Description

"Done" button should use the ButtonWidget normal style which has a border box.
Expected:

| Actual:

Help_Panel_spacing_2019-01-02.png (1×750 px, 98 KB)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Help Panel: Add frame to Done button	mediawiki/extensions/GrowthExperiments	master	+2 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• MMiller_WMF	T206711 [EPIC] Growth: help panel
		Resolved		kostajh	T212902 Help panel: Use ButtonWidget normal style for mobile confirmation screen

Event Timeline

RHo created this task.Jan 3 2019, 9:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 3 2019, 9:25 PM

RHo mentioned this in T211633: Help panel: design tweaks.Jan 3 2019, 9:54 PM

Change 482322 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Help Panel: Add frame to Done button

https://gerrit.wikimedia.org/r/482322

gerritbot added a project: Patch-For-Review.Jan 4 2019, 4:42 PM

kostajh moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 4 2019, 4:42 PM

kostajh mentioned this in rEGRE43191ca30c79: Help Panel: Add frame to Done button.Jan 4 2019, 4:46 PM

kostajh claimed this task.Jan 4 2019, 8:15 PM

Catrope moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 4 2019, 8:51 PM

Change 482322 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help Panel: Add frame to Done button

https://gerrit.wikimedia.org/r/482322

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.12; 2019-01-08).Jan 4 2019, 9:00 PM

• MMiller_WMF added a parent task: T206711: [EPIC] Growth: help panel.Jan 4 2019, 10:44 PM

• MMiller_WMF added subscribers: • MMiller_WMF, JTannerWMF, kostajh and 6 others.

Checked in betlabs:

LGTM too

• MMiller_WMF closed this task as Resolved.Jan 15 2019, 12:11 AM

• MMiller_WMF moved this task from Needs PM Review to Epics In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

jijiki mentioned this in rEGRE623ef74eb675: Help Panel: Add frame to Done button.Mar 18 2019, 4:31 PM

	F27779394: Help_Panel_spacing_2019-01-02.png
	Jan 3 2019, 9:25 PM

	F27821353: image.png
	Jan 8 2019, 12:25 PM

	F27816844: IMG_6666.PNG
	Jan 8 2019, 12:26 AM

	F27785791: Artboard Copy.png
	Jan 3 2019, 9:25 PM

Help panel: Use ButtonWidget normal style for mobile confirmation screenClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Help panel: Use ButtonWidget normal style for mobile confirmation screen
Closed, ResolvedPublic
Actions

Related Objects
Search...