Help panel: text on mobile is behaving like a link
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RHo
	Jan 3 2019, 9:27 PM

Description

In the first screen on mobile, the text that reads "Top help pages about editing" clicks like a link when tapped, even though it's just a header and not a link.

Details

	Subject	Repo	Branch	Lines +/-
	Help Panel: Output help links as plain elements, not in form layout	mediawiki/extensions/GrowthExperiments	master	+35 -29
	[proof of concept] TextWidget	mediawiki/extensions/GrowthExperiments	master	+13 -6

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		MMiller_WMF	T206711 [EPIC] Growth: help panel
		Resolved		kostajh	T212903 Help panel: text on mobile is behaving like a link

Event Timeline

RHo created this task.Jan 3 2019, 9:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 3 2019, 9:27 PM

RHo mentioned this in T211633: Help panel: design tweaks.Jan 3 2019, 9:54 PM

This is occurring because label elements on mobile OOUI are tapable. I suppose we should remove the label and add a header element.

RHo triaged this task as Lowest priority.Jan 4 2019, 6:24 PM

MMiller_WMF renamed this task from BUG: Help panel: text on mobile is behaving like a link to Help panel: text on mobile is behaving like a link.Jan 4 2019, 10:45 PM

MMiller_WMF added a parent task: T206711: [EPIC] Growth: help panel.

MMiller_WMF added subscribers: JTannerWMF, MMiller_WMF, Catrope and 5 others.

Change 483522 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] [proof of concept] TextWidget

https://gerrit.wikimedia.org/r/483522

gerritbot added a project: Patch-For-Review.Jan 10 2019, 9:26 PM

SBisson mentioned this in rEGREc82b9c2d631c: [proof of concept] TextWidget.Jan 10 2019, 9:27 PM

SBisson claimed this task.Jan 11 2019, 1:38 PM

SBisson moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 483522 abandoned by Sbisson:
[proof of concept] TextWidget

https://gerrit.wikimedia.org/r/483522

SBisson removed SBisson as the assignee of this task.Jan 11 2019, 2:02 PM

SBisson removed a project: Patch-For-Review.

SBisson moved this task from In Progress to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

kostajh claimed this task.Jan 16 2019, 6:49 PM

kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 485073 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Help Panel: Output help links as plain elements, not in form layout

https://gerrit.wikimedia.org/r/485073

gerritbot added a project: Patch-For-Review.Jan 17 2019, 6:07 PM

kostajh mentioned this in rEGRE2e7a25b2d000: Help Panel: Output help links as plain elements, not in form layout.Jan 17 2019, 6:09 PM

kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 17 2019, 6:10 PM

kostajh mentioned this in rEGREad5fa99bbc5c: Help Panel: Output help links as plain elements, not in form layout.Jan 17 2019, 7:29 PM

kostajh mentioned this in rEGRE28507d388d34: Help Panel: Output help links as plain elements, not in form layout.Jan 17 2019, 7:34 PM

SBisson mentioned this in rEGREcbcb90bbee52: Help Panel: Output help links as plain elements, not in form layout.Jan 17 2019, 8:00 PM

Change 485073 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help Panel: Output help links as plain elements, not in form layout

https://gerrit.wikimedia.org/r/485073

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.14; 2019-01-22).Jan 17 2019, 9:00 PM

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 18 2019, 5:05 AM

Etonkovidova closed this task as Resolved.Jan 19 2019, 1:39 AM

jijiki mentioned this in rEGREb78c1e124ae6: Help Panel: Output help links as plain elements, not in form layout.Mar 18 2019, 4:30 PM

jijiki mentioned this in rEGRE58f2d658e161: [proof of concept] TextWidget.