Audit HelpPanelLogger.prototype.getEditor and make any fixes as needed
Open, NormalPublic

Description

As noted in our chat, we're seeing other in cases we wouldn't expect.

kostajh created this task.Fri, Jan 4, 8:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Jan 4, 8:40 PM
kostajh renamed this task from Audit getEditor and make any fixes as needed to Audit HelpPanelLogger.prototype.getEditor and make any fixes as needed.

The other event shows up in VE because the help panel is loaded before veTarget = OO.getProp( window, 've', 'init', 'target' ); returns anything.

kostajh assigned this task to SBisson.Mon, Jan 7, 7:38 PM

Like Kosta mentioned above, the Help Panel is shown, and the "impression" event is logged, before the editor is loaded so we don't know which editor it's going to be.

Change 482840 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/MobileFrontend@master] Specify which editor is being opened in hook

https://gerrit.wikimedia.org/r/482840

Change 482851 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Fix getEditor and the logging of 'impression'

https://gerrit.wikimedia.org/r/482851

Change 482840 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Specify which editor is being opened in hook

https://gerrit.wikimedia.org/r/482840

Change 482851 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix getEditor and the logging of 'impression'

https://gerrit.wikimedia.org/r/482851

Change 483166 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@wmf/1.33.0-wmf.12] Fix getEditor and the logging of 'impression'

https://gerrit.wikimedia.org/r/483166

Change 483166 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.33.0-wmf.12] Fix getEditor and the logging of 'impression'

https://gerrit.wikimedia.org/r/483166

Mentioned in SAL (#wikimedia-operations) [2019-01-10T00:20:09Z] <catrope@deploy1001> Synchronized php-1.33.0-wmf.12/extensions/GrowthExperiments/: Help panel fixes (T212973, T212890, T213186) (duration: 00m 54s)