As noted in our chat, we're seeing other in cases we wouldn't expect.
Description
Description
Details
Details
Related Changes in Gerrit:
Customize query in gerrit
Related Objects
Related Objects
- Mentioned In
- rEGREe2a8dba1ac0b: Fix getEditor and the logging of 'impression'
rEGRE472b630e59fb: Fix getEditor and the logging of 'impression'
T213186: Help Panel: Posting to monthly help desk archive (kowiki)
T212890: Help panel: design - CTA on mobile view should be circular
rEGRE5c756139242f: Fix getEditor and the logging of 'impression'
rEGRE8da16a5e2351: Fix getEditor and the logging of 'impression' - Mentioned Here
- T212890: Help panel: design - CTA on mobile view should be circular
T213186: Help Panel: Posting to monthly help desk archive (kowiki)
Event Timeline
Comment Actions
The other event shows up in VE because the help panel is loaded before veTarget = OO.getProp( window, 've', 'init', 'target' ); returns anything.
Comment Actions
Like Kosta mentioned above, the Help Panel is shown, and the "impression" event is logged, before the editor is loaded so we don't know which editor it's going to be.
Comment Actions
Change 482840 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/MobileFrontend@master] Specify which editor is being opened in hook
Comment Actions
Change 482851 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Fix getEditor and the logging of 'impression'
Comment Actions
Change 482840 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Specify which editor is being opened in hook
Comment Actions
Change 482851 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix getEditor and the logging of 'impression'
Comment Actions
Change 483166 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@wmf/1.33.0-wmf.12] Fix getEditor and the logging of 'impression'
Comment Actions
Change 483166 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.33.0-wmf.12] Fix getEditor and the logging of 'impression'
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2019-01-10T00:20:09Z] <catrope@deploy1001> Synchronized php-1.33.0-wmf.12/extensions/GrowthExperiments/: Help panel fixes (T212973, T212890, T213186) (duration: 00m 54s)
Comment Actions
Based on the data logged in the Data Lake, this is no longer a problem. There are very few events with editor_interface set to other, typically one or two, some days none at all.