Page MenuHomePhabricator
Create Task
Maniphest T212975

[Regression pre-wmf.12] Cannot open any citation dialog or insert a new one
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Go to Insert>Template
  2. Search for a template to add and click on "Add Template: button.

The following error appears on the console.

Uncaught TypeError: this.outlineItem.setIndicator(...).setTitle is not a function

Also happens when you click on "Edit" button on the context menu to edit an existing template

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Revert "Replace deprecated `setIndicatorTitle` with `setTitle`"mediawiki/extensions/VisualEditormaster+4 -4
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Jan 4 2019, 9:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 4 2019, 9:06 PM
Ryasmeen mentioned this in T210796: The citation (with template) dialog's Apply changes action is always enabled.Jan 4 2019, 9:07 PM
Peachey88 added a project: Regression.Jan 4 2019, 11:47 PM
Schnark subscribed.Jan 5 2019, 8:48 AM

Is this T212977: Widgets should mixin TitledElement by default (OutlineOptionWidget is missing mixin), just from a different perspective?

Volker_E subscribed.Jan 5 2019, 5:53 PM

@Schnark Thanks, same cause yes.

matmarex added a comment.Jan 7 2019, 9:08 PM

Thanks for investigating. For now I'll just revert the VE patch that exposed the issue (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/482127).

gerritbot subscribed.Jan 7 2019, 9:08 PM

Change 482704 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Revert "Replace deprecated setIndicatorTitle with setTitle"

https://gerrit.wikimedia.org/r/482704

gerritbot added a project: Patch-For-Review.Jan 7 2019, 9:08 PM
matmarex triaged this task as Unbreak Now! priority.Jan 7 2019, 9:14 PM
matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptJan 7 2019, 9:14 PM
matmarex added a project: VisualEditor-MediaWiki.Jan 7 2019, 9:14 PM
matmarex moved this task from Incoming to QA on the VisualEditor (Current work) board.
gerritbot added a comment.Jan 7 2019, 9:23 PM

Change 482704 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Revert "Replace deprecated setIndicatorTitle with setTitle"

https://gerrit.wikimedia.org/r/482704

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.12; 2019-01-08).Jan 7 2019, 10:00 PM
Volker_E mentioned this in T76638: Clean up duplication between config options: TitledElement's 'title' and IconElement's 'iconTitle' / IndicatorElement's 'indicatorTitle' (deprecate and remove the latter).Jan 7 2019, 10:14 PM
Ryasmeen edited projects, added Verified; removed Patch-For-Review.Jan 8 2019, 8:03 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
greg lowered the priority of this task from Unbreak Now! to High.Jan 15 2019, 6:40 AM
greg subscribed.

Setting to High now that the code is merged and ya'll are just waiting for PO review.

• marcella closed this task as Resolved.Jan 15 2019, 2:24 PM
• marcella claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 15 2019, 2:24 PM
Liuxinyu970226 unsubscribed.Jan 16 2019, 1:32 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits