Page MenuHomePhabricator

Widgets should mixin TitledElement by default (OutlineOptionWidget is missing mixin)
Closed, ResolvedPublic

Description

Coming from https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/482145/1/resources/src/mediawiki.special.apisandbox/apisandbox.js OutlineOptionWidget nor any of its extended widgets seem to mixin TitledElement, therefore resulting in an error.

Widgets supposed to carry TitledElement mixin (already or proposed: ✓) or not (×):

  • ButtonWidget ✓
    • ActionWidget
    • PopupButtonWidget
  • ButtonGroupWidget ✓
  • DropdownWidget ✓
  • HiddenInputWidget ×
  • IconWidget ✓
  • IndicatorWidget ✓
  • InputWidget ✓
    • ButtonInputWidget
    • CheckboxInputWidget
    • CheckboxMultiselectInputWidget
    • DropdownInputWidget
    • RadioInputWidget
    • RadioSelectInputWidget
    • TextInputWidget
      • ComboboxInputWidget
      • MultilineTextInputWidget
      • NumberInputWidget
      • SearchInputWidget
  • LabelWidget ✓
  • MultioptionWidget ✓
    • CheckboxMultioptionWidget
  • MultiselectWidget ✓ (?)
    • CheckboxMultiselectWidget
  • OptionWidget ✓
    • ButtonOptionWidget
    • DecoratedOptionWidget
      • MenuOptionWidget
      • MenuSectionOptionWidget
      • OutlineOptionWidget
    • RadioOptionWidget
    • TabOptionWidget
  • OutlineControlsWidget (? ButtonWidgets already carry title out of box)
  • PopupWidget ×
  • ProgressBarWidget (?)
  • SearchWidget (?)
  • SelectFileWidget ✓
  • SelectWidget ✓
    • ButtonSelectWidget
    • MenuSelectWidget
    • OutlineSelectWidget
    • RadioSelectWidget
    • TabSelectWidget
  • TagItemWidget (? ButtonWidget carries title out of box)
  • TagMultiselectWidget ✓
    • MenuTagMultiselectWidget
    • PopupTagMultiselectWidget (deprecated)
  • ToggleWidget ✓
    • ToggleButtonWidget
    • ToggleSwitchWidget

Event Timeline

@matmarex When looking at this, I wondered, why we're not mixing in TitledElement to all widgets in general? Similar to HTML logic of [[ https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title | title attribute as global one ]]…

Hmm, on going through all widgets, there are cases like

  • HiddenInputWidget,
  • PopupWidget
  • ProgressBarWidget (maybe not?)

where it doesn't make sense too much sense.

This comment was removed by Volker_E.
Volker_E renamed this task from OutlineOptionWidget doesn't mixin TitledElement to Widgets should mixin TitledElement by default (OutlineOptionWidget is missing mixin).Jan 6 2019, 9:45 PM
Volker_E added subscribers: Esanders, Mooeypoo.

Change 482579 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] Add TitledElement mixin to all main widgets where useful

https://gerrit.wikimedia.org/r/482579

Volker_E triaged this task as Medium priority.Jan 7 2019, 7:20 AM

Change 482579 merged by jenkins-bot:
[oojs/ui@master] Add TitledElement mixin to all main widgets where useful

https://gerrit.wikimedia.org/r/482579

Volker_E claimed this task.
Volker_E moved this task from Reviewing to OOUI-0.30.1 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.30.1); removed OOUI.
Volker_E removed a project: Patch-For-Review.

Change 483796 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.30.1

https://gerrit.wikimedia.org/r/483796

Change 483796 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.30.1

https://gerrit.wikimedia.org/r/483796