Page MenuHomePhabricator

generate_family_files_tests.py is failing in TestGenerateFamilyFiles.test_attributes_after_run
Closed, ResolvedPublic

Description

Removing the @unittest.expectedFailure # T194138 for test_attributes_after_run method it fails with the following error instead of the error given in T194138. This bug was introduced with 8707292.

======================================================================
ERROR: test_attributes_after_run (__main__.TestGenerateFamilyFiles)
Test FamilyFileGenerator attributes after run().
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".\tests\generate_family_files_tests.py", line 58, in test_attributes_aft
er_run
    self.generator_instance.run()
  File "C:\pwb\GIT\core\generate_family_file.py", line 48, in run
    w = Wiki(self.base_url)
NameError: name 'Wiki' is not defined

----------------------------------------------------------------------
Ran 1 test in 0.983s

FAILED (errors=1)

Event Timeline

Change 482407 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] import MWSite in generate_family_file.py for tests

https://gerrit.wikimedia.org/r/482407

Change 482407 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] import MWSite in generate_family_file.py for tests

https://gerrit.wikimedia.org/r/482407

Xqt removed a project: Patch-For-Review.

Reopened due to failing pwb_tests and script_tests
https://api.travis-ci.org/v3/job/475754571/log.txt

I reverted py patch given above.

Xqt removed Xqt as the assignee of this task.Jan 5 2019, 6:48 PM

Change 482535 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] import MWSite in generate_family_file.py when needed

https://gerrit.wikimedia.org/r/482535

Change 482535 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] import MWSite in generate_family_file.py when needed

https://gerrit.wikimedia.org/r/482535