Page MenuHomePhabricator

Make keyboard shortcuts configurable
Closed, ResolvedPublic

Description

Currently, some keyboard shortcuts are hardcoded. The following keyboard shortcuts should be configurable, and disabling them should be possible.

  • "Y" reverts assuming good faith, with a custom edit summary.
  • "O" opens the page in an external browser
  • "H" shows the history of the page, externally
  • "Ctrl+S" nominates a page for speedy deletion
  • "Ctrl+D" deletes a page.
  • "Ctrl+Alt+W" removes whitelisted users' edits from the queue
  • "Ctrl+Alt+D" removes edits with a score lower than -200 (why hardcoded -200, by the way? I'd use this option if it was "500" or so. "-200" is below my personal ">100" list limit anyway.)
  • "Shift+I" increases "badness score"
  • "Shift+D" decreases "badness score"
  • "Ctrl+H" welcomes the user
  • "Ctrl+B" blocks the user
  • "F1" opens help. Being able to use the whole "function key" row for custom shortcuts could be useful.
  • "Ctrl+P" opens preferences. The only hardcoded requirement to prevent keyboard lockout is that the "Alt" key focuses the menu bar, and that the arrow keys and space/return can be used to navigate it when focused.
  • "Esc" does an emergency abort of delayed actions. The user may not even have enabled such a delay.
  • "Ctrl+F" is "Find". A reasonable default, but not necessary to be hardcoded either.

Example how to do this: https://github.com/huggle/huggle3-qt-lx/commit/e0dd659d1eb963db1fb692e448a3a58251a46238

Event Timeline

Petrb triaged this task as Medium priority.Jan 5 2019, 8:07 PM
Petrb added a project: good first task.

@Srilasyapragathi: Hi! This task has been assigned to you a while ago. Could you maybe share an update? Do you still plan to work on this task, or do you need any help?

If this task has been resolved in the meantime: Please update the task status (via Add Action...Change Status in the dropdown menu).
If this task is not resolved and only if you do not plan to work on this task anymore: Please consider removing yourself as assignee (via Add Action...Assign / Claim in the dropdown menu): That would allow others to work on this (in theory), as others won't think that someone is already working on this. Thanks! :)

Novem_Linguae assigned this task to Srilasyapragathi.
Novem_Linguae updated the task description. (Show Details)
Novem_Linguae subscribed.

Yeap. I see all these hotkeys in https://github.com/huggle/huggle3-qt-lx/blob/master/src/huggle_core/configuration.cpp. I think this ticket just never got updated. I'll update it now.