Page MenuHomePhabricator
Create Task
Maniphest T213009

Viewing multiple revisions that have no difference doesn't display properly
Open, MediumPublic
Actions

Description

If you select more than one revision in the History window where there is no difference (for example, a test that was self reverted), the main page display doesn't properly show that there is no difference between them.

Expected: A message by itself saying the selected revisions have no difference
Actual:

image.png (2×5 px, 1 MB)

Another weird thing that happens with this bug is it takes quiet a long time to display the above screenshot (about 5 seconds for me). My total guess based off of no information whatsoever of why that is is because it's fetching the html of the webpage as a fallback or something similar.

Event Timeline

Perryprog created this task.Jan 5 2019, 8:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 5 2019, 8:28 PM
Perryprog added a project: Huggle.Jan 5 2019, 8:32 PM
Petrb subscribed.Jan 5 2019, 9:40 PM

But it's right in the brackets: "No difference"

Petrb triaged this task as Medium priority.Jan 5 2019, 9:41 PM
Perryprog added a comment.Jan 5 2019, 9:45 PM

Sorry, let me clarify. Displaying the message "No difference" like that seems to be very inconsistent with the way diffs are usually displayed. It also shows a lot of extraneous information that isn't relevant to just saying "No difference".

P.S. Amazing avatar.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL