Page MenuHomePhabricator

Move phrase suggest related code to its FallbackMethod
Closed, ResolvedPublic

Description

The code to handle phrase suggest (current DYM suggestions provider) is spread into many places (FTQueryBuilder, SearchResponse, Searcher, SearchContext...).
To simplify the addition of new suggesters or new techniques to provide DYM suggestions we should refactor and this code to to the relevant FallbackMethod.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
dcausse triaged this task as Medium priority.

Change 482652 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Add QueryFixer

https://gerrit.wikimedia.org/r/482652

Change 482872 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Refactor phrase suggest

https://gerrit.wikimedia.org/r/482872

Change 482652 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add QueryFixer

https://gerrit.wikimedia.org/r/482652

Change 482872 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Refactor phrase suggest

https://gerrit.wikimedia.org/r/482872