Page MenuHomePhabricator
Create Task
Maniphest T213098

Move phrase suggest related code to its FallbackMethod
Closed, ResolvedPublic
Actions

Description

The code to handle phrase suggest (current DYM suggestions provider) is spread into many places (FTQueryBuilder, SearchResponse, Searcher, SearchContext...).
To simplify the addition of new suggesters or new techniques to provide DYM suggestions we should refactor and this code to to the relevant FallbackMethod.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/CirrusSearchmaster+563 -602Refactor phrase suggest
mediawiki/extensions/CirrusSearchmaster+401 -0Add QueryFixer
Customize query in gerrit

Event Timeline

dcausse created this task.Jan 7 2019, 4:49 PM
Restricted Application edited projects, added Discovery-Search; removed Discovery-Search (Current work). · View Herald TranscriptJan 7 2019, 4:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
dcausse claimed this task.Jan 7 2019, 4:49 PM
dcausse triaged this task as Medium priority.
dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.
dcausse moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.
gerritbot added a subscriber: gerritbot.Jan 8 2019, 7:33 PM

Change 482652 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Add QueryFixer

https://gerrit.wikimedia.org/r/482652

gerritbot added a project: Patch-For-Review.Jan 8 2019, 7:33 PM

Change 482872 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Refactor phrase suggest

https://gerrit.wikimedia.org/r/482872

gerritbot added a comment.Jan 10 2019, 12:10 AM

Change 482652 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add QueryFixer

https://gerrit.wikimedia.org/r/482652

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.13; 2019-01-15).Jan 10 2019, 1:00 AM
dcausse moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Jan 15 2019, 6:29 PM
dcausse removed a project: MW-1.33-notes (1.33.0-wmf.13; 2019-01-15).Jan 15 2019, 6:39 PM
gerritbot added a comment.Jan 24 2019, 12:31 PM

Change 482872 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Refactor phrase suggest

https://gerrit.wikimedia.org/r/482872

dcausse moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Jan 24 2019, 1:52 PM
debt closed this task as Resolved.Jan 26 2019, 7:28 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL