Entry points for mobileoptions, mobile.init, mobilediff and userlogin are generated via webpack
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

The 4 modules loaded on MobileOptions, MobileDiff and UserLogin and all mobile pages (mobile.init) are relatively simple. It should be trivial to port these to webpack. None of them have tests.

Acceptance criteria

The code in mobile.special.mobileoptions.scripts (no deps) is built via webpack
The code in mobile.special.mobilediff.scripts is built via webpack
The code in mobile.special.userlogin.scripts is built via webpack
The code in mobile.init is built via webpack
The code in mobile.startup has not grown in any substantial way. Consider introducing a new module mobile.special.scripts (to mirror mobile.special.styles) modules if this becomes a problem that can be shared across all special pages.

Sign off steps

We have now ported our first special page JavaScript module to webpack! \o/

Progress is updated.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/MobileFrontend	master	+578 -532	Four entry points built via webpack

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
Resolved	Jdlrobson	T195475 [EPIC] Automate asset bundling in MobileFrontend
Resolved	Jdlrobson	T207787 [EPIC] Reduce the amount of modules in MobileFrontend
Resolved	Jdrewniak	T213112 Entry points for mobileoptions, mobile.init, mobilediff and userlogin are generated via webpack

Event Timeline

Jdlrobson triaged this task as High priority.Jan 7 2019, 8:13 PM

Jdlrobson created this task.

Jdlrobson mentioned this in T212823: MFA: mobile.special.watchlist.scripts is built via Webpack.

Jdlrobson mentioned this in T207787: [EPIC] Reduce the amount of modules in MobileFrontend.

Jdlrobson moved this task from Incoming to Upcoming on the Readers-Web-Backlog board.

Jdlrobson renamed this task from Entry points for mobileoptions, mobilediff and userlogin are generated via webpack to Entry points for mobileoptions, mobile.init, mobilediff and userlogin are generated via webpack.Jan 8 2019, 2:08 AM

Jdlrobson updated the task description. (Show Details)

Jdlrobson updated the task description. (Show Details)Jan 8 2019, 2:11 AM

Jdlrobson mentioned this in T213298: Special:Uploads is built via webpack.Jan 9 2019, 3:58 PM

Jdlrobson updated the task description. (Show Details)Jan 9 2019, 6:25 PM

Jdlrobson updated the task description. (Show Details)

ovasileva set the point value for this task to 5.Jan 9 2019, 6:29 PM

ovasileva edited projects, added Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3); removed Readers-Web-Backlog.Jan 10 2019, 6:30 PM

Jdlrobson moved this task from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Jan 15 2019, 12:50 AM

Change 484341 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] 4 Entry points built via webpack

https://gerrit.wikimedia.org/r/484341

gerritbot added a project: Patch-For-Review.Jan 15 2019, 1:30 AM

Jdlrobson moved this task from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Jan 15 2019, 1:30 AM

nray moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Jan 15 2019, 11:50 PM

Change 484341 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Four entry points built via webpack

https://gerrit.wikimedia.org/r/484341

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.14; 2019-01-22).Jan 16 2019, 1:00 AM

Jdlrobson updated the task description. (Show Details)Jan 16 2019, 1:25 AM

Jdrewniak claimed this task.Jan 16 2019, 6:08 PM

Jdrewniak closed this task as Resolved.Jan 17 2019, 11:27 PM

Jdrewniak updated the task description. (Show Details)