Page MenuHomePhabricator

DropdownInputWidget should support disabled options/optgroups
Closed, ResolvedPublic

Description

It isn't possible to set DropdownInputWidget options or optgroups to be disabled from PHP.

It should be possible to pass 'disabled' = true for either type of option, e.g.:

new \OOUI\DropdownInputWidget( [
	'options' => [
		[ 'data' => 'd1', 'label' => 'Label 1' ],
		[ 'data' => 'd1', 'label' => 'Label 1', 'disabled' => true ],
	],
] );

Event Timeline

Change 482729 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[oojs/ui@master] Allow dropdown menu items to be disabled

https://gerrit.wikimedia.org/r/482729

Volker_E triaged this task as Medium priority.Jan 8 2019, 8:46 PM
Samwilson renamed this task from DropdownInputWidget in PHP can't have disabled options to DropdownInputWidget should support disabled options/optgroups.Jan 11 2019, 1:47 AM

I've extended the above patch to also support the same options format in Javascript.

Change 482729 merged by jenkins-bot:
[oojs/ui@master] Allow dropdown menu items to be disabled

https://gerrit.wikimedia.org/r/482729

Volker_E assigned this task to Samwilson.
Volker_E moved this task from Reviewing to OOUI-0.30.2 on the OOUI board.
Volker_E edited projects, added: OOUI (OOUI-0.30.2); removed: OOUI.
Volker_E removed a project: Patch-For-Review.
Volker_E awarded a token.
Volker_E removed a subscriber: gerritbot.

Change 486131 had a related patch set uploaded (by Jforrester; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.30.2

https://gerrit.wikimedia.org/r/486131

Change 486131 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.30.2

https://gerrit.wikimedia.org/r/486131