Page MenuHomePhabricator
Create Task
Maniphest T213199

Upstream Score's music icon to OOUI
Closed, ResolvedPublic
Actions

Assigned To
Esanders
Authored By
Esanders
Jan 8 2019, 5:51 PM
Tags
Referenced Files
F27915791: image.png
Jan 16 2019, 11:22 PM
F27901742: image.png
Jan 15 2019, 8:28 PM
F23880345: advanced-editing.png
Jan 8 2019, 10:52 PM
F27823401: 200px-Utah_Jazz_logo_(2016).svg.png
Jan 8 2019, 6:38 PM
F27823009: image.png
Jan 8 2019, 5:51 PM
F27823026: image.png
Jan 8 2019, 5:51 PM
F27823012: image.png
Jan 8 2019, 5:51 PM
Subscribers
Aklapper
Esanders
matmarex
Pginer-WMF
RHo
Volker_E

Description

As seen in VE:

image.png (33×143 px, 2 KB)

Currently in OOUI/media:

image.png (28×123 px, 1 KB)

As currently drawn in OOUI this doesn't represent a single musical glyph, but looks like the truncated part of a series of quavers (see illustration from en.wiki below)

image.png (376×204 px, 18 KB)

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.30.2mediawiki/coremaster+677 -544
icons: Use complete glyph for 'musicalScore' iconoojs/uimaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jan 8 2019, 5:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 8 2019, 5:51 PM
gerritbot subscribed.Jan 8 2019, 5:56 PM

Change 482859 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Use complete glyph for musicalScore icon

https://gerrit.wikimedia.org/r/482859

gerritbot added a project: Patch-For-Review.Jan 8 2019, 5:56 PM
Volker_E added a project: Design.Jan 8 2019, 6:29 PM
Volker_E added subscribers: RHo, Pginer-WMF, Volker_E.

The current iteration was specifically chosen to minimize details, this needs to go through design review (we're deliberately removing details in other icons like 'tray' or 'globe').

Pginer-WMF added a comment.Jan 8 2019, 6:38 PM

As Volker said, the intention was to make a simplified version of ♪, which is stylized with more straight lines similarly to the case of the Utah Jazz logo, for example:

200px-Utah_Jazz_logo_(2016).svg.png (87×200 px, 11 KB)

Volker_E triaged this task as Low priority.Jan 8 2019, 8:40 PM
Esanders added a comment.Jan 8 2019, 10:37 PM

To anyone who reads musical notation (the target audience here), as opposed to basketball fans, this just looks wrong.

Esanders added a comment.Jan 8 2019, 10:38 PM

Where is the task for the most recent change (from the VE version to the OOUI version)?

Volker_E added a comment.Jan 8 2019, 10:45 PM

It was T195480: Bring VE extension icons to OOUI packs and further align them, specifically T195480#4433570

Esanders added a comment.Jan 8 2019, 10:52 PM

advanced-editing.png (326×357 px, 22 KB)

The right one is more acceptable, although it is still uncommon to use stems of different lengths. If you really want to avoid the diagonal beam, you can just put the notes at the same height.

Volker_E added a comment.Jan 15 2019, 7:42 PM

Coming from Design Review, we'll follow last comment to improve readability of 'musicalScore' and go with alternative here…

Esanders added a comment.EditedJan 15 2019, 8:28 PM

To clarify, the horizontal beam would require the notes to be at the same height, as the stems should be the same height:

image.png (516×1 px, 290 KB)

Esanders added a comment.Jan 15 2019, 8:30 PM

https://en.wikipedia.org/wiki/Beam_(music)#Positioning

Volker_E moved this task from Backlog to Reviewing on the OOUI board.Jan 16 2019, 2:18 AM
gerritbot added a comment.Jan 16 2019, 8:37 PM

Change 482859 merged by jenkins-bot:
[oojs/ui@master] icons: Use complete glyph for 'musicalScore' icon

https://gerrit.wikimedia.org/r/482859

Volker_E closed this task as Resolved.Jan 16 2019, 9:08 PM
Volker_E assigned this task to Esanders.
Volker_E moved this task from Reviewing to OOUI-0.30.2 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.30.2); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.
matmarex subscribed.Jan 16 2019, 11:22 PM

New icon, for reference:

image.png (20×20 px, 189 B)

gerritbot added a comment.Jan 23 2019, 7:04 PM

Change 486131 had a related patch set uploaded (by Jforrester; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.30.2

https://gerrit.wikimedia.org/r/486131

gerritbot added a project: Patch-For-Review.Jan 23 2019, 7:04 PM
gerritbot added a comment.Jan 23 2019, 7:40 PM

Change 486131 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.30.2

https://gerrit.wikimedia.org/r/486131

Volker_E removed a project: Patch-For-Review.Feb 21 2019, 3:48 AM
Esanders mentioned this in T226168: Chemistry beaker icon should have open top.Jul 1 2019, 1:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL