| cmadeo | |
| Jan 8 2019, 7:27 PM |
| F28332870: Appearance settings as sub menu.png | |
| Mar 5 2019, 10:20 PM |
| F28295699: IMG_2666.PNG | |
| Feb 27 2019, 5:29 PM |
| F28295701: IMG_2665.PNG | |
| Feb 27 2019, 5:29 PM |
| F27261007: 04a text formatting options.png | |
| Jan 8 2019, 7:27 PM |
As an editor on the iOS app, I would like a way to be able to change the appearance of the editing view.
| Appearance settings |
 |
| Zeplin: https://zpl.io/agrRLqN |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • JMinor | T209168 Wikitext editing tools | |||
| Resolved | • JMinor | T209175 Update the header on the editing interface: As an editor on the iOS app, I would like a way to be able to easily undo and redo my changes, preview my work and change the appearance of the editing view | |||
| Resolved | Tsevener | T213208 Appearance settings in the editing view | |||
| Resolved | BUG REPORT | JoeWalsh | T218296 Appearance Settings popover intermittently loses anchor | ||
| Resolved | BUG REPORT | Tsevener | T218301 Editing background is dark gray for black theme | ||
| Resolved | BUG REPORT | JoeWalsh | T218303 Syntax Highlighting toggle slow |
I would suggest adding an additional theme css file for syntax highlighting off codemirror-none.css rather than trying to use any built in syntax highlighting toggle
I would suggest adding an additional theme css file for syntax highlighting off codemirror-none.css rather than trying to use any built in syntax highlighting toggle
...may want to try the highlighting command, which already toggles it on and off without having to adjust the css.
...may want to try the highlighting command, which already toggles it on and off without having to adjust the css.
@Mhurd according to the mockup and confirmed with @cmadeo, disabling syntax highlighting should keep underline, bold, & italic formatting while removing the colors applied to the syntax. Using CodeMirror’s maxHighlightLength removes all formatting including underline, bold, & italic. Having a separate CSS file for this state allows us to keep the desired formatting and gives us more control should we want to customize anything else about it in the future.
I notice some of the styles currently show only the tags rather than formatting the text within on the editing view (see <u>bullet</u> & <s>bullet</s> in attachment), whereas bold bullet actually is bold within the "" tag. Is this expected to change with this ticket or are we only removing colors and not adding additional formatting for the highlighted state?
FYI I have created a bug on the above comment: https://phabricator.wikimedia.org/T217275
We came to the decision of auto dismissing the keyboard when the popover is opened but NOT auto reshowing the keyboard after the popover is dismissed.
Woo! This is working really nicely! Thanks, @Tsevener!
One thing though is that the text in the Syntax highlighting label looks a bit large. Can we reduce the text size to match the size used in the toggle options in settings (eg. dim images or expand tables in the reading preferences area)?
