Page MenuHomePhabricator

Set up Wikidocumentaries for translation
Closed, ResolvedPublic

Related Objects

StatusSubtypeAssignedTask
OpenNone
ResolvedNikerabbit

Event Timeline

Susannaanas created this task.

Looking at the en.json file, I think it would be necessary to flatten it. So instead of a nested structure like you have, the strings should all be at the same level.

Flattening isn't necessary, as long as the values are only objects or strings. We just need to reserve one character as a separator that does not appear in the keys otherwise for the automatic flattening.

Change 491788 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[translatewiki@master] Add Wikidocumentaries

https://gerrit.wikimedia.org/r/491788

Patch is ready, but before I merge it: there is Finnish in https://github.com/Wikidocumentaries/wikidocumentaries-ui/blob/master/src/store/translation/en.json#L38 and I'd like to confirm that you are going to add message documentation.

Change 491788 merged by jenkins-bot:
[translatewiki@master] Add Wikidocumentaries

https://gerrit.wikimedia.org/r/491788

Should be done now. Are the existing translations preserved? They are in the same GitHub folder.

Yes they have been preserved as you can see from https://translatewiki.net/wiki/Translating:Wikidocumentaries translation statistics.

Nikerabbit claimed this task.
Nikerabbit removed a project: Patch-For-Review.

This is complete, unless I forgot something.