Page MenuHomePhabricator

OOUI JS Demo: Uncaught TypeError: this.setTitledElement is not a function
Closed, ResolvedPublic

Description

Attempting to access the JS demo for OOUI ( https://doc.wikimedia.org/oojs-ui/master/demos/?page=widgets&theme=wikimediaui&direction=ltr&platform=desktop ) on Google Chrome 71.0.3578.98 shows these two errors in the console:

jQuery.Deferred exception: this.setTitledElement is not a function TypeError: this.setTitledElement is not a function
    at new OoUiToggleButtonWidget (https://doc.wikimedia.org/oojs-ui/master/demos/dist/oojs-ui-widgets.js:2994:7)
    at new Demo (https://doc.wikimedia.org/oojs-ui/master/demos/demo.js:25:22)
    at setup (https://doc.wikimedia.org/oojs-ui/master/demos/:79:12)
    at HTMLDocument.<anonymous> (https://doc.wikimedia.org/oojs-ui/master/demos/:91:4)
    at mightThrow (https://doc.wikimedia.org/oojs-ui/master/demos/node_modules/jquery/dist/jquery.js:3534:29)
    at process (https://doc.wikimedia.org/oojs-ui/master/demos/node_modules/jquery/dist/jquery.js:3602:12) undefined
Uncaught TypeError: this.setTitledElement is not a function
    at new OoUiToggleButtonWidget (ToggleButtonWidget.js:60)
    at new Demo (demo.js:25)
    at setup (VM191:79)
    at HTMLDocument.<anonymous> (VM191:91)
    at mightThrow (jquery.js:3534)
    at process (jquery.js:3602)

Screenshot of error:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 8 2019, 11:50 PM

I think this is my fault. We made and merged https://gerrit.wikimedia.org/r/c/oojs/ui/+/482862 yesterday, before merging https://gerrit.wikimedia.org/r/c/oojs/ui/+/482579. They should have been merged in the opposite order. I just +2'd the other patch, so this should be resolved soon.

Volker_E closed this task as Resolved.Jan 10 2019, 4:59 PM
Volker_E claimed this task.
Volker_E triaged this task as Normal priority.

@Volker_E @matmarex No worries, thanks for fixing it! Much appreciated.