Page MenuHomePhabricator
Create Task
Maniphest T213456

'Structured data' header does not appear before the captions if there are no captions for an image
Closed, ResolvedPublic
Actions

Description

If no captions have been entered for an image, then the 'structured data' header is missing, which looks weird

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make sure 'structured data' header exists without datamediawiki/extensions/WikibaseMediaInfomaster+17 -14
Customize query in gerrit

Related Objects

Event Timeline

Cparle created this task.Jan 10 2019, 4:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 10 2019, 4:57 PM
• Ramsey-WMF subscribed.Jan 10 2019, 5:31 PM
gerritbot subscribed.Jan 10 2019, 5:53 PM

Change 483477 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Make sure 'structured data' header exists without data

https://gerrit.wikimedia.org/r/483477

gerritbot added a project: Patch-For-Review.Jan 10 2019, 5:53 PM
Cparle mentioned this in rEWBI3bd0f3fb7aad: Make sure 'structured data' header exists without data.Jan 10 2019, 5:57 PM
Cparle mentioned this in rEWBI1e841de72d80: Make sure 'structured data' header exists without data.Jan 10 2019, 6:10 PM
Jdforrester-WMF moved this task from To Do to Verify on Production on the Structured Data Engineering board.Jan 10 2019, 7:05 PM
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Jan 10 2019, 7:22 PM

Change 483477 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Make sure 'structured data' header exists without data

https://gerrit.wikimedia.org/r/483477

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.13; 2019-01-15).Jan 10 2019, 8:00 PM
Mike_Peel subscribed.Jan 10 2019, 8:42 PM
Jdforrester-WMF moved this task from Untriaged to Product owner backlog on the Multimedia board.Jan 11 2019, 10:23 PM
Jdforrester-WMF subscribed.

Will be deployed next week (Test Commons on 2019-01-15, Real Commons on 2019-01-16).

Jdforrester-WMF moved this task from To Do to Ready for Production Testing on the Multimedia-Team-Working-Board board.Jan 14 2019, 5:26 PM
• Ramsey-WMF closed this task as Resolved.Jan 17 2019, 8:41 PM
• Ramsey-WMF claimed this task.

Confirmed working on production.

jijiki mentioned this in rEWBI27cf7b4a3cc0: Make sure 'structured data' header exists without data.Mar 18 2019, 4:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits