Page MenuHomePhabricator

Article footer is too tall
Open, LowPublicBUG REPORT

Description

How many times were you able to reproduce it?

Always

Steps to reproduce

  1. Open any article
  2. Scroll to the bottom

Expected results

There's the same amount of space below "View article in browser" as there is between the Wikipedia wordmark and the last related article

Actual results

There's way more space below "View article in browser"

Screenshots

Environments observed

App version: 6.2 1556
OS versions: 12

Event Timeline

JoeWalsh created this task.Jan 10 2019, 6:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 10 2019, 6:38 PM
Mhurd added a subscriber: Mhurd.Jan 29 2019, 9:36 PM

This was deliberate. This is so when the last item from the TOC is selected it can be scrolled to the top of the screen in the same way as other sections.

Mhurd added a comment.Jan 29 2019, 9:39 PM

If product and design want to change this that's fine with me, but it's their call.

Mhurd added a subscriber: cmadeo.EditedFeb 4 2019, 7:16 PM

Here's the original ticket:
https://phabricator.wikimedia.org/T166609

Here's the funkiness on iPad (tap image below for animation) when using the TOC near the bottom of the article without dynamic bottom padding:

^ Note that the TOC determines which item should be selected based on which section of the article intersects the top of the screen. In this article, when scrolled to the bottom without dynamic bottom padding, that section is 2000 census. If you select any section below 2000 census you can see nothing appears to happen, which gives the appearance that the TOC buttons aren't working. Also, because the TOC monitors scrolling to determine which item should appear selected, as soon as you scroll at all after making a selection, the selected TOC item jumps back up instantly to 2000 census. See the original ticket above for more info.

Side note: I have a WIP branch from a year or 2 ago which made the TOC show *every onscreen section* as being highlighted. (tap for animation: https://github.com/wikimedia/wikipedia-ios/pull/1736) This WIP hack was an experiment, a side effect of which was no longer needing the dynamic bottom padding. @cmadeo I think it would be cool if the TOC got away from indicating a single *current* section since more than one section can be onscreen at once - especially since the heuristic we use (section intersecting top of screen) is opaque to the user.

cmadeo added a comment.Feb 5 2019, 4:20 PM

@Mhurd, thanks for sharing this! Would you mind sharing a video of the multiple section approach but with the bottom of the article? I'm a bit curious what will happen if say you click on Read more from higher up on the article view. Thanks!

Mhurd added a comment.Feb 5 2019, 7:34 PM

@cmadeo there's an animation of it on the old spike pr: https://github.com/wikimedia/wikipedia-ios/pull/1736 We could tweak the "is onscreen" indication to be anything you'd like - i think in the animation it's just making the text blue to indicate onscreen sections.

JMinor triaged this task as Low priority.Feb 15 2019, 7:00 PM
Sbailey claimed this task.Jul 10 2019, 7:14 PM
Sbailey removed Sbailey as the assignee of this task.Jul 16 2019, 3:16 PM
Sbailey added a subscriber: Sbailey.