Page MenuHomePhabricator

On Special:AllMessages the URL parameter lang with empty, invalid or unknown value selects language 'aa'
Open, Needs TriagePublicBUG REPORT

Description

Before rMWd0c31ac98888 on Special:AllMessages the URL parameter lang with empty, invalid or unknown value selected the language code of the content language for the messages and for the HTML form. Since rMWd0c31ac98888 in the HTML form the language code aa is selected in this case. The messages are still filtered in the language code of the content language.

Examples:

Event Timeline

Fomafix renamed this task from The URL lang on Special:AllMessages with empty, invalid or unknown value selects language 'aa' to On Special:AllMessages the URL parameter lang with empty, invalid or unknown value selects language 'aa'.Jan 10 2019, 9:09 PM

Change 484311 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Special:AllMessages

https://gerrit.wikimedia.org/r/484311

Change 486182 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/core@master] SpecialAllMessages: Validate language code via callback

https://gerrit.wikimedia.org/r/486182

Change 484311 abandoned by Jdlrobson:
Correct the default drop down option in Special:AllMessages

Reason:
https://gerrit.wikimedia.org/r/#/c/mediawiki/core/ /486182/ looks more promising here! Thanks fomafix

https://gerrit.wikimedia.org/r/484311

Fomafix changed the subtype of this task from "Task" to "Bug Report".Feb 28 2019, 7:58 AM

Change 486182 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/core@master] SpecialAllMessages: Validate language code via callback

https://gerrit.wikimedia.org/r/486182

Change 486182 abandoned by Fomafix:

[mediawiki/core@master] SpecialAllMessages: Validate language code via callback

Reason:

The replacement of wfGetLangObj was done in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/824144 and the input validation of the lang parameter with a warning message is done in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/830104

https://gerrit.wikimedia.org/r/486182

Change 830104 had a related patch set uploaded (by Bartosz Dziewoński; author: Fomafix):

[mediawiki/core@master] Move lang validation from AllMessagesTablePager to SpecialAllMessages

https://gerrit.wikimedia.org/r/830104

Change 830104 merged by jenkins-bot:

[mediawiki/core@master] Move lang validation from AllMessagesTablePager to SpecialAllMessages

https://gerrit.wikimedia.org/r/830104