Page MenuHomePhabricator

Takedown tools: Datepicker picking wrong dates, submitting totally different figures
Open, HighPublic2 Story Points

Description

For example, in https://lcatools.corp.wikimedia.org/takedown/157, the date and time of each upload was inputted as 1/6/2019 9:35 PM but for whatever reason ended up being submitted as 1/7/2019 5:35 AM which is totally wrong.

Event Timeline

jrbs created this task.Jan 10 2019, 10:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 10 2019, 10:23 PM
Restricted Application added a subscriber: MGChecker. · View Herald TranscriptJan 10 2019, 10:27 PM
TBolliger renamed this task from Datepicker picking wrong dates, submitting totally different figures to Takedown tools: Datepicker picking wrong dates, submitting totally different figures.Jan 10 2019, 10:31 PM
TBolliger moved this task from Untriaged to Cards ready to be estimated on the Anti-Harassment board.
jrbs triaged this task as High priority.Feb 8 2019, 8:20 PM
Niharika set the point value for this task to 2.Apr 4 2019, 6:20 PM
dbarratt claimed this task.

The issue was that the time was being converted to UTC, seems to be solved by the patch.

The "Created" time is still in UTC, but I assume that's intentional, since it wasn't reported in the task description?

The "Created" time is still in UTC, but I assume that's intentional, since it wasn't reported in the task description?

I assume it's fine as long as the datetime inputted is what you get out after saving.

@jrbs, would you mind QAing this since I don't believe @dom_walden has access to this (though, feel free to test it locally if you would like).

@dbarratt When the "Time" input is empty, if I click on it and select hour "14" it puts "13:26" (or whatever minute it is) into the input box. Perhaps it is converting to UTC, I think. But then, when I click "14" again it actually puts "14:26" into the input box.

Does it expect the time in UTC or the user's local time?

Does it expect the time in UTC or the user's local time?

It should (if working properly) expect the time in UTC

jrbs added a comment.Wed, May 22, 8:00 PM

Is there a reason it treats the time as anything other than just a direct string? I guess for structure or something?

But yes, we enter the time based on wiki data, which is in UTC. So not the user's time :)

Is there a reason it treats the time as anything other than just a direct string? I guess for structure or something?

I would add that to the long list of things that some idiot did before understanding our culture. :P