Page MenuHomePhabricator

Improve the All Edits page-loading sequence—and show a progress indicator
Open, MediumPublic5 Estimated Story Points

Description

Engineering TL;DR

  • When the user visits the All Edits page, immediately show the stored Event Summary data and page UI.
  • Then Fetch the All Edits data based on the last Update, showing the appropriate progress indicator and UI for the Fetch state at the same time. (Including the three-dot 'loading' animation that is implemented T213470: Implement UX for Updating and Downloading)
  • Only fetch the list (and pagination) between the dates of event start and last time the pageIDs were updated! In other words, don't show edits that happened after the last Update.

See "Expanded" below for a complete acceptance criteria for the feature.

NOTE: This ticket relies on terms and concepts defined in T213136, which summarizes and codifies the Updating and Downloading processes. Please make sure you have read T213136 before proceeding with this ticket.
The main parts of the All Edits page
Screen Shot 2019-01-16 at 9.42.47 AM.png (985×1 px, 236 KB)

Expanded

Current All Edits behavior

  • The user clicks to go to the All Edits page and sees only blank window and browser loading indicator--possibly for quite a while.
  • Meanwhile the system fetches both the stored Summary Data (at page top) as well as the All Edits data, based on the last update.
  • Then everything loads at once.
  • When the page loads, edits may appear that occurred after the Update time and date. This ticket adjusts all that.

Desired All Edits behavior

  • The user clicks to visit the All Edits page,
  • The page loads and displays the Event Summary data at page top, as well as the timestamp as of the last update (no Update is performed) and standard page UI (the Update button, etc.) This should be quick, since the Event Summary data is stored.
  • Then the system Fetches All Edits data based on page IDs from the last update. The system will not display any edits that are more recent than the existing timestamp, which was based on the last Update. (This data must be Fetched because it is not stored.)
  • During the Fetching process, the system displays the appropriate UI elements for the Fetch state, including the animated 3-dot Working indicator and On-Page Message (as described in T213470).
  • The system displays the first page of newly fetched All Edits data.

Pagination—each time the user clicks page navigation at bottom of the All Edits page to go back and forth among the pages of the All Edits list, the process above repeats itself. I.e.:

  • No Update occurs; the timestamp and stored Summary Data are displayed.
  • The requested page of edits is fetched, based on page IDs from the last Update.
  • The system displays the appropriate UI elements for the Fetch state, as per T213470.
  • The requested page of Fetched All Edits data is displayed.

Event Timeline

jmatazzoni removed the point value for this task.
jmatazzoni renamed this task from Fetch and populate the Edit List page when the user visits to Fetch and populate the Edit List page when the user visits the page.Jan 15 2019, 2:26 AM
jmatazzoni renamed this task from Fetch and populate the Edit List page when the user visits the page to Fetch and populate the Edit List when the user visits the page.Jan 15 2019, 6:12 PM
jmatazzoni renamed this task from Fetch and populate the Edit List when the user visits the page to Fetch and populate the Edit List page when the user visits .

@MusikAnimal please see my email, "Dow we need this Edit List ticket?" Do we?

@MusikAnimal please see my email, "Dow we need this Edit List ticket?" Do we?

I replied.

@MusikAnimal, I rewrote the ticket based on our conversation. Have a look: does this look correct now?

jmatazzoni renamed this task from Fetch and populate the Edit List page when the user visits to Improve the Edit List page loading sequence—and show a progress indicator.Jan 16 2019, 2:28 AM
jmatazzoni renamed this task from Improve the Edit List page loading sequence—and show a progress indicator to Improve the Edit List page-loading sequence—and show a progress indicator.
jmatazzoni renamed this task from Improve the Edit List page-loading sequence—and show a progress indicator to Improve the All Edits page-loading sequence—and show a progress indicator.Feb 12 2019, 11:26 PM
jmatazzoni updated the task description. (Show Details)
jmatazzoni moved this task from Product backlog to Needs Discussion on the Community-Tech board.