Page MenuHomePhabricator

Checkboxes in Preferences are clickable through the floating "Save" button
Closed, ResolvedPublic

Description

In Special:Preferences, it is possible to click a checkbox through the disabled "Save" button, meaning it's easy to (un)tick a box by accident. Hard to screenshot this bug but perhaps someone can screen capture.

Event Timeline

jrbs created this task.Jan 11 2019, 7:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 11 2019, 7:21 AM
.mw-prefs-buttons {
 z-index: 1;
}

seems to fix this.

Change 484566 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] WikimediaUI theme: Prevent z-index leaks for radios and checkboxes

https://gerrit.wikimedia.org/r/484566

@Schnark's solution is also good, but it would have to be applied separately to any form where we have such floating buttons. There is right now just one such form, but still…

Change 484566 merged by jenkins-bot:
[oojs/ui@master] WikimediaUI theme: Prevent z-index leaks for radios and checkboxes

https://gerrit.wikimedia.org/r/484566

Volker_E moved this task from Backlog to OOUI-0.30.2 on the OOUI board.Jan 16 2019, 2:18 AM
Volker_E edited projects, added OOUI (OOUI-0.30.2); removed OOUI.

Change 486131 had a related patch set uploaded (by Jforrester; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.30.2

https://gerrit.wikimedia.org/r/486131

Change 486131 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.30.2

https://gerrit.wikimedia.org/r/486131

matmarex closed this task as Resolved.Fri, Jan 25, 12:56 AM
matmarex claimed this task.
Johan added a subscriber: Johan.Wed, Jan 30, 7:56 PM

Do you have a rough idea when we could expect this in production?

It will be in the next weekly release, 1.33.0-wmf.16, to be deployed to all projects between 5 and 7 February. (Ordinarily it would happen this week, but this week's release – wmf.15 – is being skipped, as most WMF engineers are busy at the All Hands meeting this week.)