Page MenuHomePhabricator

Image links in existing media are broken
Closed, ResolvedPublic

Description

On /ticket/<x>/media/manage/, all links on the image name for images under "Remove existing media" are to /ticket/<x>/media/manage/. This is because generateImageHtml in commons-selection.js uses image.descriptionurl in line 296 but this is undefined in the case of existing images because the object returned by /api/tracker/mediainfo/?ticket=<x> doesn't have a descriptionurl key unlike the response returned by the getImages function.

Details

Related Gerrit Patches:
wikimedia-cz/tracker : masterFix image links in existing media section

Event Timeline

Shreyasminocha renamed this task from Image links in existing media give 404 to Image links in existing media are broken.Jan 11 2019, 9:22 AM
Shreyasminocha triaged this task as High priority.
Shreyasminocha created this task.
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptJan 11 2019, 12:19 PM

Change 483743 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[wikimedia-cz/tracker@master] Fix image links in existing media section

https://gerrit.wikimedia.org/r/483743

Change 483743 merged by jenkins-bot:
[wikimedia-cz/tracker@master] Fix image links in existing media section

https://gerrit.wikimedia.org/r/483743

Urbanecm closed this task as Resolved.Jan 11 2019, 12:57 PM