Page MenuHomePhabricator

Incorrect protection reason for non-source-language version of translatable banner messages
Closed, ResolvedPublic2 Story Points

Description

The non-source-langauge versions of translatable banner messages are normally edited via the Translate extension interface, at least in WMF setup. However, the protection reason automatically set says, "Only edit via Special:CentralNotice". Should be a minor fix in Banner::protectBannerContent(). See, for example, the history of this message.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 11 2019, 5:25 PM
AndyRussG updated the task description. (Show Details)Jan 11 2019, 5:26 PM

Change 475126 had a related patch set uploaded (by AndyRussG; owner: MarcoAurelio):
[mediawiki/extensions/CentralNotice@master] Improve autoprotection log reason and make it localisable

https://gerrit.wikimedia.org/r/475126

Change 475126 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Improve autoprotection log reason and make it localisable

https://gerrit.wikimedia.org/r/475126

Patch merged. Shall we close this one? Thanks.

Patch merged. Shall we close this one? Thanks.

Hi! Thanks... Usually we wait for fixes/features to be deployed to production before closing a task. In this case, the patch should go out to Meta with today's deploy train, at 20:00 UTC. (See Deployments on Wikitech.)

DStrine set the point value for this task to 2.Jun 4 2019, 3:52 AM