Page MenuHomePhabricator

change link text in embedded query flyout
Open, Needs TriagePublic

Description

Problem:
In the right-side flyout on the embedded query result page there are the options "edit" and "edit code" and "code". "Edit code" needs to be renamed because it is not the same code behind "code" but instead the SPARQL query.

Example:

query for cats

Screenshots/mockups:

Open questions:

  • What to rename it to?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2019, 4:48 PM

What does the user get if they click on "edit", then?

They get the little query builder.

Jsc39 added a subscriber: Jsc39.EditedJan 14 2019, 5:04 PM

@Lydia_Pintscher I want to work on this issue. I am a new contibutor over here. Can you guide me.

After some discussion let's go with:

  • remove the "Code" option because it is very unlikely it is needed there. It can be reached in the non-embedded mode where people are likely to need it.
  • rename "Edit code" to "Edit SPARQL" because SPARQL isn't code.
  • rename "Edit" to "Edit visually" to be clearer about what's behind it.

Change 486720 had a related patch set uploaded (by Gopavasanth; owner: Gopavasanth):
[wikidata/query/gui@master] Change link test in embedded query flyout

https://gerrit.wikimedia.org/r/486720

Change 492725 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Fully remove code examples from embed.html

https://gerrit.wikimedia.org/r/492725

Change 486720 merged by jenkins-bot:
[wikidata/query/gui@master] Change link text in embedded query flyout

https://gerrit.wikimedia.org/r/486720

Change 492727 had a related patch set uploaded (by WDQSGuiBuilder; owner: WDQSGuiBuilder):
[wikidata/query/gui-deploy@production] Merging from 5ad2e1d0b9f7051d7fc17ce60ac8ee094847c475:

https://gerrit.wikimedia.org/r/492727

Change 492727 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from 5ad2e1d0b9f7051d7fc17ce60ac8ee094847c475:

https://gerrit.wikimedia.org/r/492727

Change 492725 merged by jenkins-bot:
[wikidata/query/gui@master] Fully remove code examples from embed.html

https://gerrit.wikimedia.org/r/492725