Page MenuHomePhabricator
Create Task
Maniphest T213628

change link text in embedded query flyout
Closed, ResolvedPublic
Actions

Description

Problem:
In the right-side flyout on the embedded query result page there are the options "edit" and "edit code" and "code". "Edit code" needs to be renamed because it is not the same code behind "code" but instead the SPARQL query.

Example:

query for cats

Screenshots/mockups:

queryflyout.png (265×150 px, 5 KB)

Open questions:

  • What to rename it to?

Details

SubjectRepoBranchLines +/-
Fully remove code examples from embed.htmlwikidata/query/guimaster+6 -27
Merging from 5ad2e1d0b9f7051d7fc17ce60ac8ee094847c475:wikidata/query/gui-deployproduction+16 -16
Change link text in embedded query flyoutwikidata/query/guimaster+2 -7
Customize query in gerrit

Related Objects

Event Timeline

Lydia_Pintscher created this task.Jan 12 2019, 4:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2019, 4:48 PM
Lydia_Pintscher added a project: Wikidata.Jan 12 2019, 4:48 PM
Lydia_Pintscher added subscribers: • Hanna_Petruschat_WMDE, Jan_Dittrich, Charlie_WMDE.

@Jan_Dittrich @Charlie_WMDE @Hanna_Petruschat_WMDE: Any suggestion for a better link text?

Lydia_Pintscher added projects: good first task, Wikidata-Query-Service, patch-welcome.Jan 12 2019, 4:50 PM
Lydia_Pintscher updated the task description. (Show Details)Jan 12 2019, 4:55 PM
Jan_Dittrich added a comment.Jan 14 2019, 9:42 AM

What does the user get if they click on "edit", then?

Lydia_Pintscher added a comment.Jan 14 2019, 9:48 AM

They get the little query builder.

• Greta_Doci_WMDE subscribed.Jan 14 2019, 3:36 PM
Jsc39 subscribed.EditedJan 14 2019, 5:04 PM

@Lydia_Pintscher I want to work on this issue. I am a new contibutor over here. Can you guide me.

Smalyshev edited projects, added Wikidata Query UI; removed Wikidata-Query-Service.Jan 23 2019, 11:50 PM
Lydia_Pintscher added a comment.Jan 26 2019, 9:38 AM

After some discussion let's go with:

  • remove the "Code" option because it is very unlikely it is needed there. It can be reached in the non-embedded mode where people are likely to need it.
  • rename "Edit code" to "Edit SPARQL" because SPARQL isn't code.
  • rename "Edit" to "Edit visually" to be clearer about what's behind it.
Gopavasanth subscribed.Jan 26 2019, 9:40 AM
Gopavasanth claimed this task.Jan 26 2019, 9:57 AM
gerritbot subscribed.Jan 26 2019, 11:18 AM

Change 486720 had a related patch set uploaded (by Gopavasanth; owner: Gopavasanth):
[wikidata/query/gui@master] Change link test in embedded query flyout

https://gerrit.wikimedia.org/r/486720

gerritbot added a project: Patch-For-Review.Jan 26 2019, 11:18 AM
Gopavasanth mentioned this in rWDQG4de0c8caeb97: Change link test in embedded query flyout.Jan 26 2019, 11:21 AM
Gopavasanth mentioned this in rWDQG2a390f0c318f: Change link test in embedded query flyout.Jan 26 2019, 2:47 PM
Gopavasanth mentioned this in rWDQG2ea5f5d946bb: Change link test in embedded query flyout.Feb 22 2019, 4:38 PM
Gopavasanth mentioned this in rWDQG386456bd421d: Change link text in embedded query flyout.Feb 25 2019, 4:39 PM
gerritbot added a comment.Feb 25 2019, 4:42 PM

Change 492725 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Fully remove code examples from embed.html

https://gerrit.wikimedia.org/r/492725

Lucas_Werkmeister_WMDE mentioned this in rWDQG0ddddc028bcd: Fully remove code examples from embed.html.Feb 25 2019, 4:42 PM
gerritbot added a comment.Feb 25 2019, 4:45 PM

Change 486720 merged by jenkins-bot:
[wikidata/query/gui@master] Change link text in embedded query flyout

https://gerrit.wikimedia.org/r/486720

Gopavasanth mentioned this in rWDQG5ad2e1d0b9f7: Change link text in embedded query flyout.Feb 25 2019, 4:46 PM
Lucas_Werkmeister_WMDE mentioned this in rWDQGdd7227631c23: Fully remove code examples from embed.html.Feb 25 2019, 4:46 PM
gerritbot added a comment.Feb 25 2019, 4:47 PM

Change 492727 had a related patch set uploaded (by WDQSGuiBuilder; owner: WDQSGuiBuilder):
[wikidata/query/gui-deploy@production] Merging from 5ad2e1d0b9f7051d7fc17ce60ac8ee094847c475:

https://gerrit.wikimedia.org/r/492727

Gopavasanth mentioned this in rWDQG51e37ff71adb: Fully remove code examples from embed.html.Feb 25 2019, 6:20 PM
gerritbot added a comment.Feb 25 2019, 6:27 PM

Change 492727 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from 5ad2e1d0b9f7051d7fc17ce60ac8ee094847c475:

https://gerrit.wikimedia.org/r/492727

Gopavasanth mentioned this in rWDQGade27575cfb6: Fully remove code examples from embed.html.Feb 25 2019, 6:59 PM
gerritbot added a comment.Feb 26 2019, 8:51 PM

Change 492725 merged by jenkins-bot:
[wikidata/query/gui@master] Fully remove code examples from embed.html

https://gerrit.wikimedia.org/r/492725

jijiki mentioned this in rWDQGab303581e528: Change link text in embedded query flyout.Mar 18 2019, 4:35 PM
Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 1:39 PM
Gopavasanth removed Gopavasanth as the assignee of this task.May 26 2021, 1:04 PM
Lydia_Pintscher closed this task as Resolved.Aug 10 2022, 10:28 AM
Lydia_Pintscher claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL