Make EntityUsageTable::addUsages batchSize configurable
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Acceptance:

Batch size for other batches in the class should remain the same
Batch size should be configurable via a config option which is simply a fixed number
Default batch size for this config option should remain the same, so (100*5 = 500), so 500 (currently calculated at https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/54d283c322062e7e9ed49a6a15738bbe75d4ee10/client/includes/Usage/Sql/EntityUsageTable.php#L176-L179)
INSERT_BATCH_SIZE_FACTOR will no longer exist.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Move addEntityUsagesBatchSize setting to client config in docs	mediawiki/extensions/Wikibase	master	+2 -2
	Make EntityUsageTable::addUsages batchSize configurable	mediawiki/extensions/Wikibase	master	+52 -12

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T30599 Deadlock tracking bug (tracking)
Resolved	PRODUCTION ERROR	Ladsgroup	T205045 Exception from LinksUpdate: Deadlock found in database query (from Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages)
Resolved		Ladsgroup	T213809 Make EntityUsageTable::addUsages batchSize configurable

Event Timeline

Addshore created this task.Jan 15 2019, 11:19 AM

Addshore triaged this task as Medium priority.

Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.

Addshore updated the task description. (Show Details)Jan 15 2019, 1:50 PM

Addshore updated the task description. (Show Details)Jan 15 2019, 1:55 PM

Addshore set the point value for this task to 3.

Addshore moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.

Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Addshore updated the task description. (Show Details)Jan 15 2019, 2:12 PM

Ladsgroup claimed this task.Jan 22 2019, 2:29 PM

Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 22 2019, 2:29 PM

Change 485849 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Make EntityUsageTable::addUsages batchSize configurable

https://gerrit.wikimedia.org/r/485849

gerritbot added a project: Patch-For-Review.Jan 22 2019, 4:51 PM

Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 22 2019, 4:52 PM

Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 28 2019, 1:54 PM

Change 485849 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make EntityUsageTable::addUsages batchSize configurable

https://gerrit.wikimedia.org/r/485849

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Jan 28 2019, 7:01 PM

Ladsgroup moved this task from incoming to in progress on the Wikidata board.Jan 30 2019, 1:35 PM

Addshore closed this task as Resolved.Feb 4 2019, 9:40 AM

Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Addshore mentioned this in T215146: Decrease EntityUsageTable addUsage batch size to 300.Feb 4 2019, 9:43 AM

Change 487816 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Move addEntityUsagesBatchSize setting to client config in docs

https://gerrit.wikimedia.org/r/487816

Change 487816 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move addEntityUsagesBatchSize setting to client config in docs