JADE allows leading zeros in ids in Judgment titles
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hoo
	Jan 15 2019, 1:52 PM

Description

JADE allows creating pages like Judgment:Diff/0742 or Judgment:Revision/001 alongside of Judgment:Diff/742/Judgment:Revision/1.

	Subject	Repo	Branch	Lines +/-
	Validate for canonical page title	mediawiki/extensions/JADE	master	+27 -1

Mentioned In: rEJADc6090dec5eb6: Validate for canonical page title
rEJADe580ab7b43e1: Validate for canonical page title
rEJADace93d844c6d: Validate for canonical page title

Good find, thanks!

Do we, as a general rule, want to prevent the creation of Jade pages that do not correspond to legal revision IDs?

In T213816#4881623, @Harej wrote:

Do we, as a general rule, want to prevent the creation of Jade pages that do not correspond to legal revision IDs?

For sure—there's validation in place to mostly do that, but this bug shows that we're missing a clause like:

assert str(int(x)) == x

We probably allow "12345.0" as well, at the moment.

Another goal of our validation is to guarantee that a judgment of any given entity has exactly one, predictable, URL.

Change 484514 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/JADE@master] Validate for canonical page title

Change 484514 merged by jenkins-bot:
[mediawiki/extensions/JADE@master] Validate for canonical page title

hoo closed this task as Resolved.Jan 17 2019, 7:35 PM

hoo claimed this task.

hoo removed a project: Patch-For-Review.