Page MenuHomePhabricator

Clicking on ToC section using physical mouse sends click event to WebView, doesn't switch to correct section
Closed, ResolvedPublic

Description

When using a physical mouse to select a section from the table of contents, the click event seems to get propagated down to the WebView, which can cause links to get "clicked" and have undesirable side-effects, such as invoking a link-preview, or entering the image gallery.

Edit from original poster: Sometimes, it also ends up being sent to the wrong entry as well. I thought I was wrong about this after I tested for it and it didn't happen, but I have just experienced this additional bug again.

[Original text:]
I sometimes use a keyboard and mouse on my phone, and the Wikipedia app, in many ways, has the best support for this out of all the apps I have used.

There is one aspect, however, which I believe is a fairly recent change, where the support is not nearly as good: clicking on an article section will not take one to it when the article section list is scrolled down.

This is a nuiscience, and it is a shame that this bug exists while the rest of the UX works so well.

Please pardon me if I put this in the wrong section; this bug platform is new to me.

Event Timeline

happysmash27 renamed this task from Can not click on article sections with a mouse to [Bug] Can not click on article sections with a mouse.Jan 15 2019, 6:34 PM
happysmash27 added a project: UX-Debt.

Can you please clarify the exact steps to reproduce the issue? Where are these article sections that you are clicking? Which article are you reading? What actually happens when you click?

I don't know what I was thinking, because now when I click on sections it works. Perhaps I assumed it was broken from a similar user interface element and maybe other bugs? This is emberressing.

Clicking on it does expose a bug of links which are under the popup opening up, though. It also brings me slightly below the sections I click on, but that is another bug entirely.

Uh, how do I close an issue here?

Thank you for asking me for specific details; I probably wouldn't have noticed my strange mistake otherwise.

Should I maybe change the name of this, or make a new issue? I might have confused one of the other bugs with the menu not working at all.

Dbrant renamed this task from [Bug] Can not click on article sections with a mouse to Clicking on ToC section using physical mouse sends click event to WebView..Jan 15 2019, 7:08 PM
Dbrant updated the task description. (Show Details)

You know the original bug, where clicking on a section didn't work? Well, it appears that it actually does exist, as I have experienced it again clicking on the PNP section of https://en.wikipedia.org/wiki/Bipolar_junction_transistor?wprov=sfla1.

In this case, it just highlights an invisible entry that doesn't coorespond to where I am scrolled to.

happysmash27 renamed this task from Clicking on ToC section using physical mouse sends click event to WebView. to Clicking on ToC section using physical mouse sends click event to WebView, doesn't switch to correct section.Feb 4 2019, 5:53 PM
happysmash27 updated the task description. (Show Details)
Dbrant claimed this task.

This is already fixed (in alpha), and will make it to production soon.