| • Lea_WMDE | |
| Jan 16 2019, 11:54 AM |
| F28070686: Screen Shot 2019-01-28 at 1.46.32 PM.png | |
| Jan 29 2019, 3:29 AM |
| F28016818: Screenshot from 2019-01-24 17-26-29.png | |
| Jan 24 2019, 4:32 PM |
| F28016820: Screenshot from 2019-01-24 17-28-52.png | |
| Jan 24 2019, 4:32 PM |
| F27909849: Bildschirmfoto 2019-01-16 um 12.48.56.png | |
| Jan 16 2019, 11:54 AM |
Motivation
Users should be aware what they are looking at. As a first step, there should be a title that just says "footnote", but the goal is to show some categorization in the future (e.g. web link or publication)
Mock
Icon
Can be found in the OOUI Demos under Icons-editing-citations --> reference
Acceptance Criteria
Question to PM and possibly UX: I noticed that all existing icons are gray, not black. Well, "all existing" is more like a single icon for disambiguation pages:
The second icon is the fallback that never appears in production. It's also gray:
Should we still follow this mock?
Change 486336 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Popups@master] Add default OOUI reference icon to all reference popups
Change 486342 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Popups@master] Move default "Footnote" title from gateway to renderer
@thiemowmde I assume the disambiguation pages are part of page previews?
@alexhollender should we switch to grey then? Sounds good from my side.
Yes, disambiguation pages are handled by the regular page preview code. They are just presented a little different (with the icon and a fixed message), because it would not be terribly helpful to show a text extract from a disambiguation page.
I, personally, think the black icon and the more compact heading do make a lot of sense for our reference previews, given these popups will show much more diverse content. I just wanted to let you know we are going to introduce a little (possibly useful) inconsistency here.
Thanks Thiemo! For now, let's do what is faster, and then correct later if necessary.
Apologies for the slow reply. The disambiguation page previews @thiemowmde has referenced are a bit of a special case. The original design has actually gotten a bit malformed over time, so once they eventually get fixed they won't resemble our reference previews so closely. The gray icon (originally larger in size) was partially meant as an empty-state of sorts. Anyhow I don't think we need to worry about consistency there.
I am realizing, however, that it would be good to use the same icons (and colors) that are used in the editor:
Thanks a lot, that sounds good.
I was able to find the icons on https://doc.wikimedia.org/oojs-ui/master/demos/?page=icons in the section "Icons – editing-citation" (unfortunately, the documentation doesn't allow linking to sections). It seems it is indeed VisualEditor who needs a bit of an update now.
Change 486342 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Move default "Footnote" title from gateway to renderer
Change 486336 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Add default OOUI reference icon to all reference popups
Renamed the title of this ticket because we usually mean sth. else with "indicator" (i.e. the little bracketed numbers in the article body that indicate that there is a footnote).