The new reviewers-by-blame plugin seems to work well, since libraryupgrader started getting added to reviews for changes that touch package.json. But it's not a human, and it can't provide reviews, so it should be exempted from the plugin somehow.
Description
Description
Details
Details
Related Changes in Gerrit:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T214397 Gerrit: reviewers-by-blame plugin improvements | |||
| Declined | Paladox | T213997 Exempt libraryupgrader from Gerrit's reviewers-by-blame plugin |
Event Timeline
Comment Actions
Perhaps use plugin.reviewers-by-blame.ignoreSubjectRegEx to exclude ^build\:.* commits?
Comment Actions
Change 485180 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[All-Projects@refs/meta/config] reviewers-by-blame: ignore build upgrades
Comment Actions
While build: upgrades probably shouldn't trigger adding reviewers in mass, the patch above does not achieve excluding libraryupgrader from being added to the list of reviewers. Apologies.
Comment Actions
Change 485184 had a related patch set uploaded (by Hashar; owner: Hashar):
[All-Projects@refs/meta/config] reviewers-by-blame: default to not adding any reviewers
Comment Actions
I have made the plugin to no more add any reviewers by default (done at All-Projects.git level). So you would no more get spam notifications.
This task is still relevant though, we would most certainly need a way for users to opt-out or blacklist some at the project level.
Comment Actions
Change 485184 merged by Thcipriani:
[All-Projects@refs/meta/config] reviewers-by-blame: default to not adding any reviewers
Comment Actions
The reviewers-by-blame plugin has been removed and is extremely unlikely to be used again in its current state. Adding reviewers based on last author/committer does not quite identify an appropriate reviewer in our workflows.