Page MenuHomePhabricator

Exempt libraryupgrader from Gerrit's reviewers-by-blame plugin
Open, Needs TriagePublic

Description

The new reviewers-by-blame plugin seems to work well, since libraryupgrader started getting added to reviews for changes that touch package.json. But it's not a human, and it can't provide reviews, so it should be exempted from the plugin somehow.

Details

Related Gerrit Patches:

Event Timeline

Legoktm created this task.Jan 17 2019, 2:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 17 2019, 2:11 AM
Paladox moved this task from Backlog to Reported Upstream on the Upstream board.Jan 17 2019, 2:15 AM

Perhaps use plugin.reviewers-by-blame.ignoreSubjectRegEx to exclude ^build\:.* commits?

Change 485180 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[All-Projects@refs/meta/config] reviewers-by-blame: ignore build upgrades

https://gerrit.wikimedia.org/r/485180

Change 485180 abandoned by MarcoAurelio:
reviewers-by-blame: ignore build upgrades

https://gerrit.wikimedia.org/r/485180

While build: upgrades probably shouldn't trigger adding reviewers in mass, the patch above does not achieve excluding libraryupgrader from being added to the list of reviewers. Apologies.

Change 485184 had a related patch set uploaded (by Hashar; owner: Hashar):
[All-Projects@refs/meta/config] reviewers-by-blame: default to not adding any reviewers

https://gerrit.wikimedia.org/r/485184

I have made the plugin to no more add any reviewers by default (done at All-Projects.git level). So you would no more get spam notifications.

This task is still relevant though, we would most certainly need a way for users to opt-out or blacklist some at the project level.

Change 485184 merged by Thcipriani:
[All-Projects@refs/meta/config] reviewers-by-blame: default to not adding any reviewers

https://gerrit.wikimedia.org/r/485184