Currently, the lang variant conversions are in production, but not instrumented. We need a lang variant dashboard with metrics and we need logs regarding lang variants.
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Instrument language variant conversions | mediawiki/services/parsoid | master | +13 -0 |
Related Objects
- Mentioned In
- T205337: Extract and use a token transformation interface (API) in place of custom token handlers
T187958: Parsoid and PHP parser parse <gallery caption="…"> differently - Mentioned Here
- rGPARf1d717fdd0c0: Work around aggressive exception handling in the tokenizer
T187958: Parsoid and PHP parser parse <gallery caption="…"> differently
T205337: Extract and use a token transformation interface (API) in place of custom token handlers
Event Timeline
Seems like basic timing information for every request involving the language conversion pathway would be enough -- eg so we can tell if language conversion is increasing CPU load unreasonably. We don't necessarily need to report the balance between different languages -- although that might be helpful if there's a certain language which is causing issues, it can probably be backed out from the info we're already logging. We statically prove that the FST can't get 'stuck', so there shouldn't be any LC-specific failures to log; any code bugs should be caught with the standard Parsoid thrown-exception handling.
@Arlolra can point you to metrics that we have for wt->html and html->wt .. but we should be able to have a dashboard like https://grafana.wikimedia.org/d/000000048/parsoid-timing-wt2html ... so, (a) request rates (b) request latencies.
Change 486215 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Instrument language variant conversions
Change 486215 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Instrument language variant conversions
Mentioned in SAL (#wikimedia-operations) [2019-01-24T19:25:13Z] <arlolra> Updated Parsoid to f1d717f (T187958, T205337, T214103)