Page MenuHomePhabricator

Instrument Parsoid language variant conversions
Closed, ResolvedPublic

Description

Currently, the lang variant conversions are in production, but not instrumented. We need a lang variant dashboard with metrics and we need logs regarding lang variants.

Details

Related Gerrit Patches:
mediawiki/services/parsoid : masterInstrument language variant conversions

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 17 2019, 10:34 PM
ssastry renamed this task from Instrument Parsoid language variance conversions to Instrument Parsoid language variant conversions.Jan 17 2019, 10:35 PM
ssastry assigned this task to cscott.
ssastry triaged this task as High priority.

What sort of instrumentation were you thinking of?

Seems like basic timing information for every request involving the language conversion pathway would be enough -- eg so we can tell if language conversion is increasing CPU load unreasonably. We don't necessarily need to report the balance between different languages -- although that might be helpful if there's a certain language which is causing issues, it can probably be backed out from the info we're already logging. We statically prove that the FST can't get 'stuck', so there shouldn't be any LC-specific failures to log; any code bugs should be caught with the standard Parsoid thrown-exception handling.

@Arlolra can point you to metrics that we have for wt->html and html->wt .. but we should be able to have a dashboard like https://grafana.wikimedia.org/d/000000048/parsoid-timing-wt2html ... so, (a) request rates (b) request latencies.

Change 486215 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Instrument language variant conversions

https://gerrit.wikimedia.org/r/486215

Change 486215 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Instrument language variant conversions

https://gerrit.wikimedia.org/r/486215

Arlolra closed this task as Resolved.Feb 25 2019, 10:12 PM