Page MenuHomePhabricator

Fix use of EditPage::getContextTitle
Closed, ResolvedPublic

Description

Deprecated: Use of EditPage::getContextTitle called with no title set was deprecated in MediaWiki 1.32. [Called from EditPage::setHeaders in /media/zephyrnia/mediawiki/core/includes/EditPage.php at line 2451] in /media/zephyrnia/mediawiki/core/includes/debug/MWDebug.php on line 309
  • affects both hubs and lists (shockingly)
  • are both still using basically the same implementation of the editpage extending? Or are they extending an extending with the common stuff?

Whatever, figure it out.

Event Timeline

Change 493245 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/extensions/CollaborationKit@master] explicitly call setContextTitle in EditPage extensions

https://gerrit.wikimedia.org/r/493245

Change 493246 had a related patch set uploaded (by Isarra; owner: Jack Phoenix):
[mediawiki/extensions/CollaborationKit@master] Call setContextTitle() before calling EditPage magic methods

https://gerrit.wikimedia.org/r/493246

Change 493245 abandoned by Isarra:
explicitly call setContextTitle in EditPage extensions

Reason:
Other one's better.

https://gerrit.wikimedia.org/r/493245

Change 493246 merged by jenkins-bot:
[mediawiki/extensions/CollaborationKit@master] Call setContextTitle() before calling EditPage magic methods

https://gerrit.wikimedia.org/r/493246

Isarra claimed this task.