Page MenuHomePhabricator

CollaborationHub and List edit tabs should not say 'Edit source' when VE is installed
Open, Needs TriagePublic

Description

Default 'edit' gets overridden/changed by VE to be 'edit source', which is misleading here - JSON is the source; this is the rich editor.

Possible options include:

  1. Getting VE to stop blindly ploughing over every content model when its function is to add a new editing mode only to a specific one
  2. Killing the normal edit tab entirely and just adding a new one VE or other such extensions won't mess with
  3. Giving up

2 is an insanely bad idea because it will break skin compatibility out the wazzoo - turns out a lot of skins in fact do expect the main edit tab/button/whatever to be listed in the navigation info under 'edit', and indeed usually expect it to be in that precise spot/order in the array as well, so randomly changing that is going to cause some problems.

1 might work and has been filed under T222115.

Event Timeline

Schniggendiller renamed this task from Create new label for 'edit' for fancy collaboartionhub/list editing to Create new label for 'edit' for fancy collaborationhub/list editing.Jan 18 2019, 4:39 PM
Isarra renamed this task from Create new label for 'edit' for fancy collaborationhub/list editing to CollaborationHub and List edit tabs should not say 'Edit source' when VE is installed.EditedApr 29 2019, 10:14 PM
Isarra added a project: VisualEditor.
Isarra updated the task description. (Show Details)

So I'm going with 3 for now because doing anything about this from here just seems so completely infeasible at present.

Given that this is caused specifically by VE, and is not an issue without VE, and cannot be resolved in CK because VE prevents it, how is this not a VE problem?