Page MenuHomePhabricator

Switch the 2010 wikitext editor's EditAttemptStep logging to the client side
Open, Needs TriagePublic

Description

Currently, the init and saveSuccess events (unlike all the other events) are logged server-side. This makes comparative analysis of the editing interfaces difficult (e.g. T209995).

We should switch them to be logged client-side like with the visual editor.

Event Timeline

Neil_P._Quinn_WMF added a subscriber: DLynch.

Perhaps I can convince you to do the dirty work, @DLynch? 😁

I'm not sure if we can without changing the meanings of them, though. At least the timings will change, and no longer really be measuring the same thing as the VE timings for the same events. E.g. init will suddenly become the same thing as ready/loaded. There's also not a great place to do saveSuccess client-side, since it'd be on the redirect to a regular article page...

Neil_P._Quinn_WMF removed Neil_P._Quinn_WMF as the assignee of this task.Jan 19 2019, 12:58 AM

If we are to do the timing the same way VE does it, then init should fire when the edit tab is clicked, and ready/loaded should fire on the edit page after init.

The main problem here is that the events take place on two different pages in the client (read/edit), but perhaps we could persist the start time in session storage?

There's also not a great place to do saveSuccess client-side, since it'd be on the redirect to a regular article page...

There's a postEdit hook that fires in the client, albeit slightly later than the when the current server saveSuccess event fires.